-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding type to param of non-parenthesized arrow function throws error #374
Comments
Nice, I like this bug! It shows the benefit of the library and how it can abstract away these problems. I'll fix this tomorrow evening. |
Hehe, sounds good! And yes, that is a good call and a huge benefit of ts-simple-ast! Thanks for taking a look :) |
Hey @gregjacobs, this is fixed in 12.7.2. Also fixed for Let me know if you run into or think of any more scenarios. Thanks! |
Very nice, thanks man! Nice implementation too 😄 Appreciate it! |
…forgotten when adding parens. Fix using the wrong word in an internal comment.
…setting its initializer, type, or adding a question token.
…forgotten when adding parens. Fix using the wrong word in an internal comment.
Now this one might be a bit of a challenge...
I tried to add a type annotation to a parameter of an arrow function where the arrow's single parameter is not surrounded by parenthesis:
Here's my reproduction of the error:
Which results in:
I think it may be ending up with this output text after the replacement:
Rather than:
The text was updated successfully, but these errors were encountered: