Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deferred memoize #435

Closed
dsherret opened this issue Sep 27, 2018 · 0 comments
Closed

Deferred memoize #435

dsherret opened this issue Sep 27, 2018 · 0 comments
Labels
performance

Comments

@dsherret
Copy link
Owner

There are several parts of the code that will memoize on creation to prevent becoming out of date when a manipulation happens (ex. .getNode() on DocumentSpan). These should instead only memoize when a manipulation happens.

This would increase the performance for renaming.
@dsherret dsherret mentioned this issue Sep 27, 2018
Closed
dsherret added a commit that referenced this issue Sep 28, 2018
@dsherret
perf: #435 - Memoize only before source file manipulation for some wr…
ad06259 
…apped language service source file dependent objects.
dsherret added a commit that referenced this issue May 14, 2019
@dsherret
perf: #435 - Memoize only before source file manipulation for some wr…
2b1f25d 
…apped language service source file dependent objects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dsherret