Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ExtensionType type aliases internal #441

Closed
dsherret opened this issue Sep 29, 2018 · 0 comments
Closed

Make ExtensionType type aliases internal #441

dsherret opened this issue Sep 29, 2018 · 0 comments
Labels
breaking change

Comments

@dsherret
Copy link
Owner

They should be changed from...

export declare type ModiferableNodeExtensionType = Node;

...to...

declare type ModiferableNodeExtensionType = Node;

...in the declaration file. They're not necessary for use outside the library and only create noise in the named exports.
dsherret added a commit that referenced this issue Sep 29, 2018
@dsherret
refactor: #441 - Make "XExtensionType" type aliases internal.
9ad6372 
BREAKING CHANGE: The "XExtensionType" type aliases are now internal. They were hidden because they're not useful outside the library and only create noise in the named exports.
dsherret added a commit that referenced this issue May 14, 2019
@dsherret
refactor: #441 - Make "XExtensionType" type aliases internal.
c1701d3 
BREAKING CHANGE: The "XExtensionType" type aliases are now internal. They were hidden because they're not useful outside the library and only create noise in the named exports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dsherret