Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename StructureTypeGuard methods to remove word "Node" #619

Closed
dsherret opened this issue May 4, 2019 · 0 comments
Closed

Rename StructureTypeGuard methods to remove word "Node" #619

dsherret opened this issue May 4, 2019 · 0 comments
Labels
breaking change
Milestone
Version 3.0

Comments

@dsherret
Copy link
Owner

dsherret commented May 4, 2019 •
edited

That was a bit of an oversight, but this looks weird:

if (StructureTypeGuards.isExportableNode(structure))
    structure.isExported = false;

Should be this:

if (StructureTypeGuards.isExportable(structure))
    structure.isExported = false;

Also, probably isClassDeclaration should be just isClass.
@dsherret dsherret added this to the 3.0.0 milestone May 15, 2019
dsherret added a commit that referenced this issue May 18, 2019
@dsherret
refactor: #619 - Rename StructureTypeGuards methods to remove word …
97379e1 
…`Node` and `Declaration` in certain cases.

BREAKING CHANGE: Renamed `StructureTypeGuards` methods to remove word `Node` and `Declaration` in certain cases.
dsherret added a commit that referenced this issue May 18, 2019
@dsherret
refactor: #619 - Rename StructureTypeGuards methods to remove word …
92331e1 
…`Node` and `Declaration` in certain cases.

BREAKING CHANGE: Renamed `StructureTypeGuards` methods to remove word `Node` and `Declaration` in certain cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
Version 3.0
Development

No branches or pull requests
1 participant
@dsherret