Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getNodesToReturn needs to handle leading trivia that could cause a comment node #648

Closed
dsherret opened this issue Jun 18, 2019 · 0 comments
Closed

getNodesToReturn needs to handle leading trivia that could cause a comment node #648

dsherret opened this issue Jun 18, 2019 · 0 comments
Labels
bug
Milestone
Version 3.0

Comments

@dsherret
Copy link
Owner

Right now getNodesToReturn is not robust and leadingTrivia specified on some structures could be returned rather than the nodes that were inserted.

To be honest, I kind of want to remove returning the nodes for insertXs and addXs methods. It's probably not used most of the time and slows things down.
@dsherret dsherret added the bug label Jun 18, 2019
@dsherret dsherret added this to the 3.0.0 milestone Jun 27, 2019
dsherret added a commit that referenced this issue Jun 29, 2019
@dsherret
fix: #648 - Comment nodes are no longer accidentally returned in some…
ad4c64c 
… scenarios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Version 3.0
Development

No branches or pull requests
1 participant
@dsherret