Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TypeGuards to be static members of Node #760

Closed
dsherret opened this issue Nov 18, 2019 · 0 comments
Closed

Move TypeGuards to be static members of Node #760

dsherret opened this issue Nov 18, 2019 · 0 comments
Labels
breaking change
Milestone
Version 6.0

Comments

@dsherret
Copy link
Owner

dsherret commented Nov 18, 2019 •
edited

I've always kind of cringed reading code like TypeGuards.isClassDeclaration(node). What would be better is Node.isClassDeclaration(node).

By the way, it used to be node.isClassDeclaration(), but that caused autocomplete to have way too many methods.

This should be released with a code mod.
@dsherret dsherret added this to the Version Next milestone Nov 18, 2019
dsherret added a commit that referenced this issue Nov 24, 2019
@dsherret
feat: #760 - Move TypeGuards to be static members of Node (methods st…
9b1e659 
…ill exist on TypeGuards, but will be removed later).

Also fixes #728.

Squashed commit of the following:

commit 4c290e2
Author: David Sherret <dsherret@gmail.com>
Date:   Sun Nov 24 15:16:22 2019 -0500

    #728 - Fix compile errors.

commit d985b3f
Author: David Sherret <dsherret@gmail.com>
Date:   Sun Nov 24 14:43:47 2019 -0500

    fix: #728.

commit 3bfd8a9
Author: David Sherret <dsherret@gmail.com>
Date:   Sun Nov 24 14:23:51 2019 -0500

    Get syntax kinds from typescript type declaration file.

    This was a bug before because the syntax kinds could be out of date in the tsMorph import.

commit 98c2d41
Author: David Sherret <dsherret@gmail.com>
Date:   Sun Nov 24 13:40:59 2019 -0500

    Move static methods from `TypeGuards` to `Node`.

commit 9f2874c
Author: David Sherret <dsherret@gmail.com>
Date:   Sat Nov 23 20:57:07 2019 -0500

    Change directory of some name nodes.
@dsherret dsherret mentioned this issue Nov 24, 2019
Closed
@dsherret dsherret modified the milestones: Version Next, Version 6 Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
Version 6.0
Development

No branches or pull requests
1 participant
@dsherret