Question about a upgrade TS to version 3.9

[szagi3891]

Can I ask for upgrading the TS version to 3.9?

The current version of morph does not want to work with the new TS.

Argument of type 'import("/home/grzegorz/Pulpit/Projekty/gpp-website3/node_modules/ts-morph/lib/ts-morph").Node<import("/home/grzegorz/Pulpit/Projekty/gpp-website3/node_modules/@ts-morph/common/node_modules/typescript/lib/typescript").Node>' is not assignable to parameter of type 'import("/home/grzegorz/Pulpit/Projekty/gpp-website3/node_modules/ts-morph/lib/ts-morph").Node<import("/home/grzegorz/Pulpit/Projekty/gpp-website3/node_modules/typescript/lib/typescript").Node>

[jasonkuhrt]

Thanks for the great project @dsherret. We're also awaiting it in graphql-nexus/nexus#859. I'll try to find time in the coming days to help with a pull-request.

[dsherret]

Sorry, missed this until now and upgrading wasn't a priority since there wasn't much changes in TS 3.9. I did have this done locally on my machine though with the RC version, so I just had to change it to 3.9.2.

Highly recommend using the ts export from ts-morph to ensure both your code and ts-morph are using the same compiler version so you don't run into trouble 🙂

import { ts } from "ts-morph";

I'll do a release for this soon.

[szagi3891]

Thank you very much. This completely solves my problem :)

[jasonkuhrt]

Hey @dsherret Maybe I missed something but IIUC 3.9 isn't supported yet. Can we keep this issue open until it is? Will make things easier to track on my side, if you don't mind!

[dsherret]

@jasonkuhrt I just forgot to merge master into latest (done now). Forgot I was trying that branching strategy for this project. I just double checked on npm and it's specifying 3.9.2.

[jasonkuhrt]

Ah awesome! Thanks

[jasonkuhrt]

Just to follow up on my comments above, it turns out our issue was never related to ts-morph. If you're curious it looks like TS 3.9 has a regression. TS Playground link. TS issue.