Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow setType on binding patterns #1380

Merged
merged 2 commits into from Mar 16, 2023
Merged

fix: allow setType on binding patterns #1380

merged 2 commits into from Mar 16, 2023

Conversation

jquense
Copy link
Contributor

@jquense jquense commented Jan 9, 2023

fixes #1223

@jquense
Copy link
Contributor Author

jquense commented Jan 9, 2023

not sure where the other file diff comes from, maybe b/c i ran format on it.

dsherret
dsherret approved these changes Mar 16, 2023
View reviewed changes
Copy link
Owner

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsherret dsherret merged commit d58f238 into dsherret:latest Mar 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InvalidOperationError when trying to set the type of a ArrayBindingPattern or ObjectBindingPattern
2 participants
@jquense @dsherret