Relaxed ts dependency #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to get generating the declaration file working.
This makes the "ensure-no-declaration-file-errors" check pass.
…ration file errors.
Kind of annoyed at how npm doesn't support aliased packages. Will only support yarn.lock going forward.
dsherret
added a commit
that referenced
this pull request
May 14, 2019
The typescript declaration file is no longer stored internally in the library. I would like to widen support for 3.1.x, but that compiler version seems slightly broken. It resolves a lot of types to `any` within this library. I will need to investigate and report the issue to the typescript team if it hasn't been reported (or perhaps it's an issue internally in the library).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaxes the typescript dependency to support TypeScript versions 3.0.1 and 3.0.3 instead of only 3.0.3.
I would like to expand support up to 3.1.x, but that version of the compiler seems to resolve a lot of the types in this library to "any". I'll have to investigate why and report to the typescript team later.