Set file editor mode based on filename #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #276 +/- ##
==========================================
Coverage 94.26% 94.26%
Complexity 336 336
==========================================
Files 47 47
Lines 855 855
==========================================
Hits 806 806
Misses 49 49 Continue to review full report at Codecov.
|
dshoreman
approved these changes
Oct 5, 2020
dshoreman
changed the title
…Name to detect nginx conf files properly If findModeByExtension doesn't match anything it automatically tries to find a match via findModeByExtension if that fails to return info as well we try to determine a mode by calling CodeMirror.findModeByMIME
dshoreman
force-pushed
the
bug-codemirror-detect-nginx-conf-files
branch
from
bc12cec
to
6cd022e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
CodeMirror.findModeByExtensionwithCodeMirror.findModeByFileNameto detect nginx conf files properly.If
findModeByFileNamedoesn't match anything it automatically tries to find a match viafindModeByExtension. If that fails to return info as well we try to determine a mode by callingCodeMirror.findModeByMIME.This is the discussion + pr in the codemirror repo
codemirror/codemirror5#2940
codemirror/codemirror5#3027
Fixes #187