Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add DOS guards #493

Open
sou-chon opened this issue May 19, 2020 · 2 comments
Open

add DOS guards #493

sou-chon opened this issue May 19, 2020 · 2 comments

Comments

@sou-chon
Copy link
Collaborator

maybe add a debounce functionality if the same IP requests too fast ?
@fguitton
Copy link
Member

It depends what kind of DoS you want to protect from. What is your threat model in this case ? A rate limiter similar to the one present in Optimise would help fix some of that and address issues pointed at in https://lgtm.com

@sou-chon
Copy link
Collaborator Author

since the user needs to be logged in to do anything it's okay i think. The one function that needs to be protected is reset password

fguitton added a commit that referenced this issue Jun 1, 2021
@fguitton
Merge pull request #493 from ideafast/dependabot/npm_and_yarn/develop…
a882492 
…/chalk-4.1.1

Bump chalk from 4.1.0 to 4.1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fguitton @sou-chon