Replace FB trend category header

[icambron]

So...this was driving me crazy:

I ended up changing a bunch of stuff, either because I didn't understand some of it, or seemed like the leftovers of past experiments. Anyway, take what you want.

[dslounge]

I think you got rid of the ability to see the original facebook trends. Is that what you were going for?

[dslounge]

I can see how that functionality seemed lost anyway once the extension got screwed up. Originally the extension kept the FB trends container div, just in case anybody wanted to see them.

[icambron]

Yeah, I saw all that, but I couldn't figure out how to actually use it, so I figured "he must have originally had a toggle to see the FB stuff, but then abandoned it".

[dslounge]

Yeah I think that functionality broke when FB changed the layout
On Oct 7, 2015 11:46, "Isaac Cambron" notifications@github.com wrote:

In background.js
#7 (comment):

 line("--init--");

- fbTrendsContainer.hide();

• redditTrendsTitle.html(redditTitleText);

- fbTrendsTitle.html(fbTitleText);

• fbTrendsTitle.addClass("fbredd-link-inactive");
• redditTrendsTitle.click(function(){

•    fbTrendsContainer.hide();
  

- redditContainer.show();

•    fbTrendsTitle.addClass("fbredd-link-inactive");
  

•    redditTrendsTitle.removeClass("fbredd-link-inactive");
  

- });

• fbTrendsTitle.click(function(){

Yeah, I saw all that, but I couldn't figure out how to actually use it, so
I figured "he must have originally had a toggle to see the old stuff, but
then abandoned it".

—
Reply to this email directly or view it on GitHub
https://github.com/dslounge/fbRedditTrends/pull/7/files#r41406991.

[icambron]

Honestly, no one who installs this extension will want to see the FB trends.

[dslounge]

I actually want to see the fb trends from time to time.
On Oct 7, 2015 12:05, "Isaac Cambron" notifications@github.com wrote:

In background.js
#7 (comment):

 line("--init--");

- fbTrendsContainer.hide();

• redditTrendsTitle.html(redditTitleText);

- fbTrendsTitle.html(fbTitleText);

• fbTrendsTitle.addClass("fbredd-link-inactive");
• redditTrendsTitle.click(function(){

•    fbTrendsContainer.hide();
  

- redditContainer.show();

•    fbTrendsTitle.addClass("fbredd-link-inactive");
  

•    redditTrendsTitle.removeClass("fbredd-link-inactive");
  

- });

• fbTrendsTitle.click(function(){

Honestly, no one who installs this extension will want to see the FB
trends.

—
Reply to this email directly or view it on GitHub
https://github.com/dslounge/fbRedditTrends/pull/7/files#r41409629.

[dslounge]

But anyway, thanks! I'll grab the fix and and get it out. I also want to do a add other sources like hackernews and product hunt, and set it up so that datasources are easy to add.