Let the OS pick a random port for us #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! 馃憢 I ran into this repo while looking around for hole punching stuff. I found a possible improvement. I don't know if this has been considered and rejected for some reason already or not. But I thought I would submit it and see if you like it.
By binding to port zero the OS will pick a random free port
to bind to for us. This has multiple advantages over picking a random
port ourselves:
operation. The OS will make sure we get one that is free.