Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor logging #1050

Closed
dennissiemensma opened this issue Jul 16, 2020 · 1 comment
Closed

Refactor logging #1050

dennissiemensma opened this issue Jul 16, 2020 · 1 comment
Milestone
4.0

Comments

@dennissiemensma
Copy link
Member

Currently the application uses at many files:

logger = logging.getLogger('dsmrreader')

This should be refactored to just use the global (root) logger as logging.x().
@dennissiemensma dennissiemensma added this to the 4.0 milestone Jul 20, 2020
@dennissiemensma
Copy link
Member Author

dennissiemensma commented Jul 20, 2020 •
edited
Loading

Using the root logger has some side effects. I'll just refactor the custom loggers to a single one.

@dennissiemensma dennissiemensma changed the title Refactor logger Refactor logging Jul 20, 2020
dennissiemensma added a commit that referenced this issue Jul 20, 2020
@dennissiemensma
Refactor logging #1050
7309117
dennissiemensma added a commit that referenced this issue Jul 20, 2020
@dennissiemensma
Log warnings and errors to database #1050
0a92f1a
dennissiemensma added a commit that referenced this issue Jul 20, 2020
@dennissiemensma
Revert "Log warnings and errors to database #1050"
c826c3b 
This reverts commit 0a92f1a
dennissiemensma added a commit that referenced this issue Jul 29, 2020
@dennissiemensma
Improved handling of DSMRREADER_LOGLEVEL #1050
ea360f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
1 participant
@dennissiemensma