New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align GasConsumption.read_at to represent the start of hour #40
Comments
Very nice F() field:
|
Running across a bug where statistics generation is halted when no gas data is found. |
Fixed it, by making gas optional, which was required anyway due to #34 |
Refactored a bit so the ORM's queries made more sense: MySQL:
PostgreSQL:
|
Merged, along with bugfix for #50. |
Deployed. |
I've seem to have created a bug in calculating gas consumption, using the new logic.
At least we still have te source readings to recalculate the consumption retroactive. |
Fixed bug and added migration to recalculate incorrect data. |
Originally reported by: Dennis Siemensma (Bitbucket: dennissiemensma, GitHub: dennissiemensma)
Currently
GasConsumption.read_at
represents the passed hour read, so the end timestamp of the hour. We should make that the start of the hour instead.Now
read_at = 22:00 = reading was between 21:00 and 22:00
Aligned
read_at = 21:00 = reading was between 21:00 and 22:00
Should not be very hard to alter, as migrations will be easy in the database (-1 hour).
The text was updated successfully, but these errors were encountered: