Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://docs.python.org/2/library/ctypes.html the find_library
function should be called "without any prefix like lib, suffix like .so,
.dylib or version number".
change _LIBRARY_NAME from "libarchive" to "archive" as required
move find_library logic after the *_LIBRARY_PATH logic to preserve
current behavior. I suspect that the LD_LIBRARY_PATH logic is not
actually necessary, but a side effect of this bug. I'm leaving it
alone because I can't test all existing configurations to confirm
that.
if find_library returns a result, use it unconditionally. Trying to
confirm it is unnecessary (find_library would have returned None
otherwise) and impossible without duplicating all of the linker's
logic. The result will be something like "libarchive.so.13" (without
a path) which will just do the right thing when used with LoadLibrary.
remove note about installing libarchive-dev, that isn't needed