Commits on Aug 8, 2018

1. fix ctypes.util.find_library usage …

   Per https://docs.python.org/2/library/ctypes.html the find_library
   function should be called "without any prefix like lib, suffix like .so,
   .dylib or version number".
   
    - change _LIBRARY_NAME from "libarchive" to "archive" as required
   
    - move find_library logic after the *_LIBRARY_PATH logic to preserve
      current behavior. I suspect that the LD_LIBRARY_PATH logic is not
      actually necessary, but a side effect of this bug. I'm leaving it
      alone because I can't test all existing configurations to confirm
      that.
   
    - if find_library returns a result, use it unconditionally. Trying to
      confirm it is unnecessary (find_library would have returned None
      otherwise) and impossible without duplicating all of the linker's
      logic. The result will be something like "libarchive.so.13" (without
      a path) which will just do the right thing when used with LoadLibrary.
   
    - remove note about installing libarchive-dev, that isn't needed

   

   mstone232 committed Aug 8, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for a282f9e
   • Browse repository at this point

   Copy the full SHA

   a282f9e View commit details

   Browse the repository at this point in the history