Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix thresholding ties bug #133

Closed
thcrock opened this issue Apr 28, 2017 · 0 comments
Closed

Fix thresholding ties bug #133

thcrock opened this issue Apr 28, 2017 · 0 comments
Assignees
@thcrock
Milestone
v0.4

Comments

@thcrock
Copy link
Contributor

thcrock commented Apr 28, 2017

When there are ties, the prediction probability->label sorting inflates precision and recall. Here is a fix, courtesy of @k1aus

test_predictions_sorted, test_label_sorted = zip(*sorted(zip(test_predictions, test_label),key=lambda pair: pair[0], reverse=True))
@thcrock thcrock added the bug label Apr 28, 2017
@thcrock thcrock mentioned this issue Apr 28, 2017
Closed
@thcrock thcrock added this to the v0.4 milestone Apr 28, 2017
@thcrock thcrock self-assigned this Apr 28, 2017
ecsalomon added a commit that referenced this issue Apr 28, 2017
@ecsalomon
Merge pull request #135 from dssg/thresholding_ties_bug
f8acbf2 
Fix thresholding ties bug [Resolves #133]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thcrock thcrock

Labels
None yet
Projects
None yet
Milestone
v0.4
Development

No branches or pull requests
1 participant
@thcrock