Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple label windows causes label generator to delete some data #156

Closed
thcrock opened this issue May 5, 2017 · 0 comments
Closed

Multiple label windows causes label generator to delete some data #156

thcrock opened this issue May 5, 2017 · 0 comments
Assignees
@thcrock
Milestone
v0.4

Comments

@thcrock
Copy link
Contributor

thcrock commented May 5, 2017

Since generate_all_labels deletes the labels table at the beginning, it should be able to actually generate all labels for an experiment. Currently it only takes one label window, which means that it must be called multiple times to work with multiple label windows.
@thcrock thcrock added the bug label May 5, 2017
@thcrock thcrock self-assigned this May 5, 2017
thcrock added a commit that referenced this issue May 5, 2017
@thcrock
Handle multiple label window sin LabelGenerator#generate_all_labels [R…
ae811b9 
…esolves #156]

- Add inner loop in LabelGenerator#generate_all_labels that handles multiple label_windows
@thcrock thcrock mentioned this issue May 5, 2017
Merged
@thcrock thcrock added this to the v0.4 milestone May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thcrock thcrock

Labels
None yet
Projects
None yet
Milestone
v0.4
Development

No branches or pull requests
1 participant
@thcrock