Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cohort/Labels tables should be namespaced by their own config, not the experiment #574

Closed
thcrock opened this issue Jan 24, 2019 · 0 comments
Closed

Cohort/Labels tables should be namespaced by their own config, not the experiment #574

thcrock opened this issue Jan 24, 2019 · 0 comments
Assignees
@thcrock

Comments

@thcrock
Copy link
Contributor

thcrock commented Jan 24, 2019

Right now very little reuse of cohorts and labels are possible because their tables are namespaced by their experiment hash. If we namespaced by their name+query hash, we could reuse them much more.
@thcrock thcrock self-assigned this Jan 24, 2019
thcrock added a commit that referenced this issue Jan 24, 2019
@thcrock
Namespace cohort and labels tables by their config [Resolves #574]
bbc1a1b 
- Change cohort and label names to include their respective name and
query hash
- Back-update algorithm doc to refer to cohort table instead of old
state table
- Modify algorithm and running docs to reflect the cohort/label table
changes
- Add validation that enforces cohort and label names are table-safe
thcrock added a commit that referenced this issue Jan 24, 2019
@thcrock
Namespace cohort and labels tables by their config [Resolves #574]
a95a414 
- Change cohort and label names to include their respective name and
query hash
- Back-update algorithm doc to refer to cohort table instead of old
state table
- Modify algorithm and running docs to reflect the cohort/label table
changes
- Add validation that enforces cohort and label names are table-safe
thcrock added a commit that referenced this issue Jan 24, 2019
@thcrock
Namespace cohort and labels tables by their config [Resolves #574]
e552126 
- Change cohort and label names to include their respective name and
query hash
- Back-update algorithm doc to refer to cohort table instead of old
state table
- Modify algorithm and running docs to reflect the cohort/label table
changes
- Add validation that enforces cohort and label names are table-safe,
introducing the hypothesis library to perform hypothesis testing of this
function
@thcrock thcrock closed this as completed in 18726a0 Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thcrock thcrock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thcrock