Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log more split info [Resolves #124] #134

Merged
merged 2 commits into from
Apr 28, 2017
Merged

Log more split info [Resolves #124] #134

merged 2 commits into from
Apr 28, 2017

Conversation

thcrock
Copy link
Contributor

@thcrock thcrock commented Apr 28, 2017

Information like lookback durations is tougher to include here because that info doesn't travel with the split, but this level of information is easy to provide.

@codecov-io
Copy link

codecov-io commented Apr 28, 2017

Codecov Report

Merging #134 into master will increase coverage by 1%.
The diff coverage is 80%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #134    +/-   ##
========================================
+ Coverage    87.8%   88.81%    +1%     
========================================
  Files          22       22            
  Lines        1156     1305   +149     
========================================
+ Hits         1015     1159   +144     
- Misses        141      146     +5
Impacted Files Coverage Δ
triage/pipelines/base.py 97.12% <100%> (-1.03%) ⬇️
triage/pipelines/serial.py 89.18% <100%> (+0.3%) ⬆️
triage/pipelines/local_parallel.py 62.06% <100%> (ø) ⬆️
triage/model_trainers.py 90.62% <62.5%> (+0.07%) ⬆️
triage/db.py 88.76% <0%> (-0.65%) ⬇️
triage/scoring.py 98.86% <0%> (-0.15%) ⬇️
triage/utils.py 93.43% <0%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44bb3ea...4c246cb. Read the comment docs.

@ecsalomon ecsalomon merged commit de29893 into master Apr 28, 2017
@ecsalomon ecsalomon deleted the log_more_split_info branch April 28, 2017 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants