individual feature importances should be optional #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SingleThreadExperiment (Related (Fixes?)to #360). QUESTION: Someone knows how to add this to MultiCore?
|
I would recommend doing this by giving the IndividualImportanceCalculator a blank set of methods instead of creating new code paths in the experiment subclasses. You can trigger this in a config file now by actually making the methods list an empty list, but I do agree that making this behavior default is preferable so the ExperimentBase could treat make empty list the default instead of ['uniform'] |
|
HOLD this PR Inserting |
hakoenig
added a commit
that referenced
this pull request
Feb 2, 2018
|
Duplicate of #379 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not in all the experiments we want that, and it has problems with
DummyClassifier(see #360).This PR:
Individual feature importances is optional for ExperimentBase and for SingleThreadExperiment (Related (Fixes?)to #360). QUESTION: Someone knows how to add this to MultiCore?