inserting NULLs for individual feature importance - #361 #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thcrock
requested changes
Feb 2, 2018
| @@ -154,7 +154,7 @@ def _save_feature_importances(self, model_id, feature_importances, feature_names | |||
| model_id=model_id, | |||
| feature_importance=0, | |||
| feature='Algorithm does not support a standard way' + | |||
| 'to calculate feature importance.', | |||
| ' to calculate feature importance.', | |||
There was a problem hiding this comment.
We should probably define this as a constant in one of the files and import it from the other. It would be way too easy for somebody to come in and reformat this line or add a word and break the other check.
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
==========================================
- Coverage 90.92% 90.88% -0.04%
==========================================
Files 61 61
Lines 3648 3655 +7
==========================================
+ Hits 3317 3322 +5
- Misses 331 333 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some classifiers do not support feature importance. For them, we write
Algorithm does not support a standard way to calculate feature importance.into results.feature_importance as feature_name. This leads to problems when trying to write individual feature importance because the feature does not exist in the matrix. This PR checks for the fake feature name and sets the individual importances to Nulls.