Implement getting OCI offers #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBits
reviewed
May 14, 2024
| result = {} | ||
| for future in as_completed(future_to_region_name): | ||
| region_name = future_to_region_name[future] | ||
| shape_names = {shape.shape for shape in future.result()} |
There was a problem hiding this comment.
future.result() can throw exceptions. I suggest adding exception handling here.
There was a problem hiding this comment.
Apparently we don't do exception handling in backends/<backend>/resources.py for any of the backends, so it is expected that these functions can raise backend-specific exceptions and the caller is responsible for handling them.
I don't see any backend-specific exception handling in <Backend>Compute.get_offers either. All exceptions raised when getting offers are handled and logged by get_offers' caller here.
r4victor
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another part of the Oracle Cloud Infrastructure backend implementation (#1194). Behind the OCI_BACKEND feature flag.