Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lookup in formPopup.comp.tsx to work with json objects #144

Merged
merged 7 commits into from
Jul 20, 2020
Merged

Fix lookup in formPopup.comp.tsx to work with json objects #144

merged 7 commits into from
Jul 20, 2020

Conversation

s4ke
Copy link
Contributor

@s4ke s4ke commented Jul 17, 2020

fixes #142

@s4ke
Copy link
Contributor Author

s4ke commented Jul 17, 2020

requires #141 to be merged first

@s4ke s4ke closed this Jul 17, 2020
@s4ke s4ke reopened this Jul 17, 2020
@s4ke
Copy link
Contributor Author

s4ke commented Jul 17, 2020

requires #141 to be merged first.

dsternlicht
dsternlicht requested changes Jul 19, 2020
View reviewed changes
Copy link
Owner

@dsternlicht dsternlicht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is ok, but it looks like you included other changes in this PR. Can you please split them into a different PR?

@s4ke
Copy link
Contributor Author

s4ke commented Jul 20, 2020

Hey,

I thought that #141 would be merged before this, so I branched off my current development state since I am testing everything against my REST API. If #141 is okay I would suggest we revisit this PR after it is merged?

@dsternlicht dsternlicht merged commit 91ad57c into dsternlicht:master Jul 20, 2020
@dsternlicht
Copy link
Owner

@s4ke no need. All approved :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsternlicht dsternlicht dsternlicht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'object' fields are not being rendered if dataPath is set in config.json
2 participants
@s4ke @dsternlicht