Update Ruby version constraints to allow Ruby v2.6 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update gemspec to allow Ruby versions >= 2.2.2 and < 2.7. Also update Travis to test for Ruby v2.6
"On January 3rd 2019 the Bundler team released Bundler 2.0 which dropped support for Ruby versions 2.2 and older" (Travis, https://docs.travis-ci.com/user/languages/ruby/#bundler-20). To make tests pass for Ruby v2.2, explicitly require installation of Bundler v1.x.
When running tests for Ruby v2.6, allow tests with ActiveRecord 4.0 and ActiveRecord 4.1 to fail. This mirrors the setup for Ruby v2.4 and Ruby v2.6.
|
Not sure why code coverage decreased 😭 |
|
Hey @dtaniwaki — just following up on this. Any chance of merge? 🙂 |
|
@dtaniwaki — any update on this? Would love to keep using this official repository rather than creating/maintaining my own fork of it. |
dtaniwaki
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Great gem! I just updated to Ruby v2.6, but acts_as_hashids is unhappy with my update. I pulled this repo and ran all tests locally with Ruby v2.6 and everything appears fine.
Thoughts? 😁