Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #232. Replace MPI deprecated functions. #237

Open
wants to merge 1 commit into
base: Develop
Choose a base branch
from

Conversation

kandread
Copy link

No description provided.

Copy link

@jcphill jcphill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this?

@@ -227,12 +227,12 @@ offsets[0] = 0;
oldtypes[o] = MPI_LONG;
blockcounts[0]= 2;

MPI_Type_extent(MPI_LONG, &extent);
MPI_Type_get_extent(MPI_LONG, &extent);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the &lb parameter.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, that whole section is commented out, so it would compile regardless.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add it there too just in case. Let me know.

@kandread
Copy link
Author

Did you test this?

I did test it against TauDEM-Test-Data (had to remove a duplicate test that made bats error out) and everything passed (attached the test.log).

@maelle
Copy link

maelle commented Sep 19, 2022

👋 @dtarb @jcphill @kandread, and thanks you all for your work on TauDEM. What is the status of this PR?

To be to install TauDEM (with mpiexec (OpenRTE) 4.0.3) I had to use these changes plus the ones in kandread#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants