Fixes #232. Replace MPI deprecated functions. #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcphill
suggested changes
Feb 24, 2022
| @@ -227,12 +227,12 @@ offsets[0] = 0; | |||
| oldtypes[o] = MPI_LONG; | |||
| blockcounts[0]= 2; | |||
|
|
|||
| MPI_Type_extent(MPI_LONG, &extent); | |||
| MPI_Type_get_extent(MPI_LONG, &extent); | |||
There was a problem hiding this comment.
Actually, that whole section is commented out, so it would compile regardless.
There was a problem hiding this comment.
I can add it there too just in case. Let me know.
I did test it against TauDEM-Test-Data (had to remove a duplicate test that made bats error out) and everything passed (attached the test.log). |
|
👋 @dtarb @jcphill @kandread, and thanks you all for your work on TauDEM. What is the status of this PR? To be to install TauDEM (with mpiexec (OpenRTE) 4.0.3) I had to use these changes plus the ones in kandread#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.