Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: the regridded values by point2grid covers the partial area of the to_grid with GFS Ocean data input #2936

Closed
23 tasks
hsoh-u opened this issue Jul 11, 2024 · 0 comments · Fixed by #2945
Closed
23 tasks
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue MET: PreProcessing Tools (Point) priority: medium Medium Priority reporting: DTC NCAR Base NCAR Base DTC Project requestor: METplus Team METplus Development Team type: bug Fix something that is not working
Milestone

Comments

@hsoh-u
Copy link
Collaborator

hsoh-u commented Jul 11, 2024

Replace italics below with details for this issue.

Describe the Problem

Provide a clear and concise description of the bug here.

The valid values are too small from the regridded outpiut by point2grid with GSF Ocean data input

Command:

/d1/personal/hsoh/git/pull_request/MET_feature_2857_tripolar_coordinates/bin/point2grid /d1/projects/MET/MET_issues/feature_2857/GFSv17_ocean/gfs.ocean.t00z.6hr_avg.f006.nc G179 testing_GFSocean.nc -field 'name="SST"; level="(0,,)";' -config /d1/personal/hsoh/data/MET-2857/Point2GridConfig_SST -v 4

The log message

DEBUG 4: regrid_nc_variable() -> [Count] data cells: 627, missing: 112687, non_missing: 449964, non mapped cells: 975993 out of 977132
DEBUG 4:        Range:  data: [-1.775440216 - 32.39379501]

Only 0.064% cells have the valid values and the rest of them are missing values.

Other command produces all missing values:
/d1/personal/hsoh/git/pull_request/MET_feature_2857_tripolar_coordinates/bin/point2grid /d1/projects/MET/MET_issues/feature_2857/GFSv17_ocean/gfs.ocean.t00z.6hr_avg.f006.nc "stereo 304 448 33.92 279.26 135.0 25 6367.47 70.0 N" testing_GFSocean.nc -field 'name="SST"; level="(0,,)";' -config /d1/personal/hsoh/data/MET-2857/Point2GridConfig_SST -v 4

WARNING:
WARNING: regrid_nc_variable() ->  There are no matching cells between input and the target grid.
WARNING:
DEBUG 2: Range of data (name="SST"; level="(0,*,*)";)
DEBUG 2:        input: -1.90645 to 32.4159      regridded: -9999 to -9999.

Expected Behavior

Provide a clear and concise description of what you expected to happen here.

The valid values should more than 1%.

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next bugfix version
  • Select Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Select MET-X.Y.Z Development project for development toward the next official release

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next bugfix version
    Select: Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Close this issue.
@hsoh-u hsoh-u added type: bug Fix something that is not working priority: medium Medium Priority alert: NEED ACCOUNT KEY Need to assign an account key to this issue reporting: DTC NCAR Base NCAR Base DTC Project requestor: METplus Team METplus Development Team MET: PreProcessing Tools (Point) labels Jul 11, 2024
@hsoh-u hsoh-u added this to the MET 12.0.0 milestone Jul 11, 2024
@hsoh-u hsoh-u self-assigned this Jul 11, 2024
@hsoh-u hsoh-u mentioned this issue Jul 11, 2024
16 tasks
hsoh-u pushed a commit that referenced this issue Aug 14, 2024
hsoh-u pushed a commit that referenced this issue Aug 15, 2024
@hsoh-u hsoh-u linked a pull request Aug 15, 2024 that will close this issue
17 tasks
hsoh-u added a commit that referenced this issue Aug 15, 2024
* #2936 Support 1D lat/lon values

* #2936 Change obs_type to TYPE_NCCF if FileType_NcCF is given from the config file

---------

Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue MET: PreProcessing Tools (Point) priority: medium Medium Priority reporting: DTC NCAR Base NCAR Base DTC Project requestor: METplus Team METplus Development Team type: bug Fix something that is not working
Projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

1 participant