Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main_v9.1-ref after #1730 #1732

Merged
merged 27 commits into from Mar 20, 2021
Merged

Update main_v9.1-ref after #1730 #1732

merged 27 commits into from Mar 20, 2021

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Mar 20, 2021

Pull Request Testing

  • Describe testing already performed for these changes:

    Update main_v9.1-ref after the met-9.1.3 bugfix release in PR Feature 1723 9.1.3 #1730.
    I checked the NB output on kiowa and confirmed that all diffs are due to MTD version number changing from 9.1.2 to 9.1.3:
kiowa:/d1/projects/MET/MET_regression/main_v9.1/NB20210320> egrep -i "ERROR:|file1" test_regression_20210320.log | egrep -B 1 ERROR:
file1: MET-main_v9.1-ref/test_output/mtd/mtd_BASIC_20100517_010000V_2d.txt
ERROR: compareStat() failed
file1: MET-main_v9.1-ref/test_output/mtd/mtd_BASIC_20100517_010000V_3d_pair_cluster.txt
ERROR: compareStat() failed
file1: MET-main_v9.1-ref/test_output/mtd/mtd_BASIC_20100517_010000V_3d_pair_simple.txt
ERROR: compareStat() failed
file1: MET-main_v9.1-ref/test_output/mtd/mtd_BASIC_20100517_010000V_3d_single_cluster.txt
ERROR: compareStat() failed
file1: MET-main_v9.1-ref/test_output/mtd/mtd_BASIC_20100517_010000V_3d_single_simple.txt
ERROR: compareStat() failed
--
file1: MET-main_v9.1-ref/test_output/mtd/mtd_CONV_TIME_20100517_010000V_2d.txt
ERROR: compareStat() failed
file1: MET-main_v9.1-ref/test_output/mtd/mtd_CONV_TIME_20100517_010000V_3d_pair_cluster.txt
ERROR: compareStat() failed
file1: MET-main_v9.1-ref/test_output/mtd/mtd_CONV_TIME_20100517_010000V_3d_pair_simple.txt
ERROR: compareStat() failed
file1: MET-main_v9.1-ref/test_output/mtd/mtd_CONV_TIME_20100517_010000V_3d_single_cluster.txt
ERROR: compareStat() failed
file1: MET-main_v9.1-ref/test_output/mtd/mtd_CONV_TIME_20100517_010000V_3d_single_simple.txt
ERROR: compareStat() failed
--
file1: MET-main_v9.1-ref/test_output/mtd/mtd_SINGLE_20100517_010000V_2d.txt
ERROR: compareStat() failed
file1: MET-main_v9.1-ref/test_output/mtd/mtd_SINGLE_20100517_010000V_3d_single_simple.txt
ERROR: compareStat() failed
--
file1: MET-main_v9.1-ref/test_output/python/mtd_PYTHON_20050807_120000V_2d.txt
ERROR: compareStat() failed
file1: MET-main_v9.1-ref/test_output/python/mtd_PYTHON_20050807_120000V_3d_pair_cluster.txt
ERROR: compareStat() failed
file1: MET-main_v9.1-ref/test_output/python/mtd_PYTHON_20050807_120000V_3d_pair_simple.txt
ERROR: compareStat() failed
file1: MET-main_v9.1-ref/test_output/python/mtd_PYTHON_20050807_120000V_3d_single_cluster.txt
ERROR: compareStat() failed
file1: MET-main_v9.1-ref/test_output/python/mtd_PYTHON_20050807_120000V_3d_single_simple.txt
ERROR: compareStat() failed
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    None needed.
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
    None needed.
  • Do these changes include sufficient testing updates? [Yes]
    None needed.
  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

    As described above.

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

JohnHalleyGotway and others added 26 commits November 6, 2020 22:14
…entoried. This helps debugging issues with MET potentially not reading all input GRIB2 records on WCOSS.
* Per #1562, check for bad data values before adding data to the PDF's for grid_diag.

* Per #1562, removing the poly = CONUS.poly mask from GridDiagConfig_TMP. That settting masked a problem in the handling of missing data. Exercising the mask.poly option is tested in another unit test. This will change the output and break the nightly build, but that's good since we'll do more thorough testing.
…to print out some additional log messages that may help in debugging the intermittent file list failure.
* Per #1572, delete the docs/version file as it is not needed here.

* Per #1572, update the version number to 9.1.1.

* Per #1572, list the met-9.1.1 release date as 20201119 for the docs.

* Per #1572, add release notes for the met-9.1.1 verison.

* Per #1572, add release notes for met-9.1.1 version.

* Per #1572, let's try to release met-9.1.1 today 11/18.
Co-authored-by: Howard Soh <hsoh@kiowa.rap.ucar.edu>
…ded in the next bugfix release for met-9.1. (#1640)
…ba array of booleans. This is used to keep track of whether or not the point should be excluded from the statistics and is used in the Ensemble-Stat. This same aggregation code in the vx_statistics library is used by Stat-Analysis. Since Stat-Analysis failed to populate that array, it led to an array parsing error in ECNTInfo::set() when trying to compute the sum of the weights. (#1707)
* Per #1710, update the release notes and version numbers for the 9.1.2 release.

* Per #1710, add a release note about the move to read the docs.
…th_pbl_91

Bugfix 1715 pb2nc seg fault with pbl 91
* Per #1716, committing the same bugfix to the main_v9.1 branch for inclusion in the 9.1.3 bugfix release.

* Per #1716, change SFP50 example to SFP33.3 to show an example of using floating point percentile values.
@JohnHalleyGotway JohnHalleyGotway added this to the met-9.1.3 (bugfix) milestone Mar 20, 2021
@JohnHalleyGotway JohnHalleyGotway added this to In progress in METplus Version 3.1 Support via automation Mar 20, 2021
@JohnHalleyGotway JohnHalleyGotway merged commit eeecc49 into main_v9.1-ref Mar 20, 2021
METplus Version 3.1 Support automation moved this from In progress to Done Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants