Feature 250 test event equalize #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… version of ubuntu no longer has python 3.8.6 available.
…feature_250_test_event_equalize
bikegeek
added
priority: high
…nline strong start-string without end-string.
jprestop
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
I added the "==1.6.2" to "netcdf" in the nco_metcalcpy_requirements.txt file, and I am happy to report that the event equalization tests now pass on WCOSS2 Acorn!
The documentation test was not passing due to this warning for release-notes.rst:
WARNING: Inline strong start-string without end-string.
Once I added a fix for that, all of the documentation tests now pass. I approve this request. Thanks for your work on this! I see this is in a feature branch going into develop. @bikegeek, will there also be a fix for main_v2.0? I think we had discussed having these fixes in a bugfix branch for main_v2.0 but can't remember the details or if that is correct.
22 tasks
add python 3.10 to testing to evaluate package compatibility
remove Python 3.10 there are issues with HDF5
bikegeek
added a commit
that referenced
this pull request
Jan 18, 2023
* Update unit_tests.yml replace 3.8.6 and 3.8.12 with 3.8 for Python because latest version of ubuntu does not have support for python 3.8.6 * Feature 251 test scorecard (#253) * Issue #251 In Pandas 1.3 and above, the SettingWithCopy Warning category has been removed. Replace the check for category=SettingWithCopyWarning with Warning, since SettingWithCopyWarning is a subclass of Warning * Added ending asterisks for end bold to fix these warnings: WARNING: Inline strong start-string without end-string. Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Feature 250 test event equalize (#252) * Remove Python 3.8.6 and 3.8.12 and use Python 3.8 instead. The latest version of ubuntu no longer has python 3.8.6 available. * Issue #250 fix the test_equalize_axis_data_no_fcst_var fixture * Added ending asterisks for end bold to fix these warnings: WARNING: Inline strong start-string without end-string. * #251 allow test to run check on numpy types regardless of numpy version * Update unit_tests.yml add python 3.10 to testing to evaluate package compatibility * Update unit_tests.yml remove Python 3.10 there are issues with HDF5 Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Delete requirements_36.txt Python 3.6 no longer supported * #249 Add test_future_warnings test * #249 additional sample data * Update requirements.txt https://github.com/dtcenter/METcalcpy/security/dependabot/22 * Update requirements.txt https://github.com/dtcenter/METcalcpy/security/dependabot/20 * #249 replacing pd.append with pd.concat and adding tests and data * #249 added tests * #249 Additional test data * Revert "Merge branch 'develop' of https://github.com/dtcenter/METcalcpy into bugfix_249_warnings" This reverts commit 7f203bf, reversing changes made to dd87d77. Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
bikegeek
removed
the
alert: NEED ACCOUNT KEY
bikegeek
added a commit
that referenced
this pull request
Feb 23, 2023
* Bump pillow from 8.3.2 to 9.3.0 (#260) Bumps [pillow](https://github.com/python-pillow/Pillow) from 8.3.2 to 9.3.0. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst) - [Commits](python-pillow/Pillow@8.3.2...9.3.0) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bugfix 251 test scorecard (#256) * Replace Python versions 3.8.6 and 3.8.12 with 3.8 * Bugfix #251 replace SettingWithCopyWarning with Warning. SettingWithCopyWarning no longer available for this check * Adding double asterisks to end bolding on mulitple lines Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * bugfix_249_warnings (#261) * Update unit_tests.yml replace 3.8.6 and 3.8.12 with 3.8 for Python because latest version of ubuntu does not have support for python 3.8.6 * Feature 251 test scorecard (#253) * Issue #251 In Pandas 1.3 and above, the SettingWithCopy Warning category has been removed. Replace the check for category=SettingWithCopyWarning with Warning, since SettingWithCopyWarning is a subclass of Warning * Added ending asterisks for end bold to fix these warnings: WARNING: Inline strong start-string without end-string. Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Feature 250 test event equalize (#252) * Remove Python 3.8.6 and 3.8.12 and use Python 3.8 instead. The latest version of ubuntu no longer has python 3.8.6 available. * Issue #250 fix the test_equalize_axis_data_no_fcst_var fixture * Added ending asterisks for end bold to fix these warnings: WARNING: Inline strong start-string without end-string. * #251 allow test to run check on numpy types regardless of numpy version * Update unit_tests.yml add python 3.10 to testing to evaluate package compatibility * Update unit_tests.yml remove Python 3.10 there are issues with HDF5 Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Delete requirements_36.txt Python 3.6 no longer supported * #249 Add test_future_warnings test * #249 additional sample data * Update requirements.txt https://github.com/dtcenter/METcalcpy/security/dependabot/22 * Update requirements.txt https://github.com/dtcenter/METcalcpy/security/dependabot/20 * #249 replacing pd.append with pd.concat and adding tests and data * #249 added tests * #249 Additional test data * Revert "Merge branch 'develop' of https://github.com/dtcenter/METcalcpy into bugfix_249_warnings" This reverts commit 7f203bf, reversing changes made to dd87d77. Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Adding file based on testing on Acorn for NCO (#265) * Per #267, updating modulefiles * Adding script for testing on WCOSS2 * Correcting filename * Bugfix release (#272) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> Co-authored-by: Hank Fisher <fisherh@ucar.edu>
bikegeek
added a commit
that referenced
this pull request
Feb 23, 2023
* Delete requirements_36.txt Python 3.6 no longer supported * #249 Add test_future_warnings test * #249 additional sample data * Bugfix Issue #249 Future Warnings- replace append with pd.concat * Bugfix issue #249 add the test for future warnings * Bugfix #249 additional data * Bugfix Issue #249 additional data that wasn't previously committed * Bugfix #249 add sum stat import * Bugfix #249 added workflow to check for Python package vulnerabilities * Updated requirements.txt for nco and all others * issue #249 add imports to pandas and warning * Bugfix 249 future warnings (#280) * Bump pillow from 8.3.2 to 9.3.0 (#260) Bumps [pillow](https://github.com/python-pillow/Pillow) from 8.3.2 to 9.3.0. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst) - [Commits](python-pillow/Pillow@8.3.2...9.3.0) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bugfix 251 test scorecard (#256) * Replace Python versions 3.8.6 and 3.8.12 with 3.8 * Bugfix #251 replace SettingWithCopyWarning with Warning. SettingWithCopyWarning no longer available for this check * Adding double asterisks to end bolding on mulitple lines Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * bugfix_249_warnings (#261) * Update unit_tests.yml replace 3.8.6 and 3.8.12 with 3.8 for Python because latest version of ubuntu does not have support for python 3.8.6 * Feature 251 test scorecard (#253) * Issue #251 In Pandas 1.3 and above, the SettingWithCopy Warning category has been removed. Replace the check for category=SettingWithCopyWarning with Warning, since SettingWithCopyWarning is a subclass of Warning * Added ending asterisks for end bold to fix these warnings: WARNING: Inline strong start-string without end-string. Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Feature 250 test event equalize (#252) * Remove Python 3.8.6 and 3.8.12 and use Python 3.8 instead. The latest version of ubuntu no longer has python 3.8.6 available. * Issue #250 fix the test_equalize_axis_data_no_fcst_var fixture * Added ending asterisks for end bold to fix these warnings: WARNING: Inline strong start-string without end-string. * #251 allow test to run check on numpy types regardless of numpy version * Update unit_tests.yml add python 3.10 to testing to evaluate package compatibility * Update unit_tests.yml remove Python 3.10 there are issues with HDF5 Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Delete requirements_36.txt Python 3.6 no longer supported * #249 Add test_future_warnings test * #249 additional sample data * Update requirements.txt https://github.com/dtcenter/METcalcpy/security/dependabot/22 * Update requirements.txt https://github.com/dtcenter/METcalcpy/security/dependabot/20 * #249 replacing pd.append with pd.concat and adding tests and data * #249 added tests * #249 Additional test data * Revert "Merge branch 'develop' of https://github.com/dtcenter/METcalcpy into bugfix_249_warnings" This reverts commit 7f203bf, reversing changes made to dd87d77. Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Adding file based on testing on Acorn for NCO (#265) * Per #267, updating modulefiles * Adding script for testing on WCOSS2 * Correcting filename * Bugfix release (#272) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> Co-authored-by: Hank Fisher <fisherh@ucar.edu> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> Co-authored-by: Hank Fisher <fisherh@ucar.edu>
fisherhucar
added a commit
that referenced
this pull request
Feb 23, 2023
* Delete requirements_36.txt Python 3.6 no longer supported * #249 Add test_future_warnings test * #249 additional sample data * Bugfix Issue #249 Future Warnings- replace append with pd.concat * Bugfix issue #249 add the test for future warnings * Bugfix #249 additional data * Bugfix Issue #249 additional data that wasn't previously committed * Bugfix #249 add sum stat import * Bugfix #249 added workflow to check for Python package vulnerabilities * Updated requirements.txt for nco and all others * issue #249 add imports to pandas and warning * Bugfix 249 future warnings (#280) * Bump pillow from 8.3.2 to 9.3.0 (#260) Bumps [pillow](https://github.com/python-pillow/Pillow) from 8.3.2 to 9.3.0. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst) - [Commits](python-pillow/Pillow@8.3.2...9.3.0) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bugfix 251 test scorecard (#256) * Replace Python versions 3.8.6 and 3.8.12 with 3.8 * Bugfix #251 replace SettingWithCopyWarning with Warning. SettingWithCopyWarning no longer available for this check * Adding double asterisks to end bolding on mulitple lines Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * bugfix_249_warnings (#261) * Update unit_tests.yml replace 3.8.6 and 3.8.12 with 3.8 for Python because latest version of ubuntu does not have support for python 3.8.6 * Feature 251 test scorecard (#253) * Issue #251 In Pandas 1.3 and above, the SettingWithCopy Warning category has been removed. Replace the check for category=SettingWithCopyWarning with Warning, since SettingWithCopyWarning is a subclass of Warning * Added ending asterisks for end bold to fix these warnings: WARNING: Inline strong start-string without end-string. Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Feature 250 test event equalize (#252) * Remove Python 3.8.6 and 3.8.12 and use Python 3.8 instead. The latest version of ubuntu no longer has python 3.8.6 available. * Issue #250 fix the test_equalize_axis_data_no_fcst_var fixture * Added ending asterisks for end bold to fix these warnings: WARNING: Inline strong start-string without end-string. * #251 allow test to run check on numpy types regardless of numpy version * Update unit_tests.yml add python 3.10 to testing to evaluate package compatibility * Update unit_tests.yml remove Python 3.10 there are issues with HDF5 Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Delete requirements_36.txt Python 3.6 no longer supported * #249 Add test_future_warnings test * #249 additional sample data * Update requirements.txt https://github.com/dtcenter/METcalcpy/security/dependabot/22 * Update requirements.txt https://github.com/dtcenter/METcalcpy/security/dependabot/20 * #249 replacing pd.append with pd.concat and adding tests and data * #249 added tests * #249 Additional test data * Revert "Merge branch 'develop' of https://github.com/dtcenter/METcalcpy into bugfix_249_warnings" This reverts commit 7f203bf, reversing changes made to dd87d77. Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Adding file based on testing on Acorn for NCO (#265) * Per #267, updating modulefiles * Adding script for testing on WCOSS2 * Correcting filename * Bugfix release (#272) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> Co-authored-by: Hank Fisher <fisherh@ucar.edu> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> Co-authored-by: Hank Fisher <fisherh@ucar.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Create a python 3.8 conda environment with these NCO metcalcpy minimal requirements:
Run tests using this script (to run only the 'basic' tests that don't use image comparison 3rd party packages):
run_basics.sh.txt
Verified that the specified tests passed (some tests are skipped in test_agg_stats_and_boots.py because they take a very long time to run) .
NOTE test_scorecard.py tests will fail because there is another Github issue #251 for addressing the SettingWithCopyWarning category (that has been removed from pandas versions that are >1.3.x).
Follow the steps above on 'acorn' and verify same results.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [For NCO deadline].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes