Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance METdataio schema to load the TOTAL_DIR column added to the VL1L2, VAL1L2, and VCNT line types during the MET 12.0.0 beta5 development cycle #307

Closed
7 of 21 tasks
JohnHalleyGotway opened this issue May 21, 2024 · 0 comments · Fixed by #311
Closed
7 of 21 tasks

Enhance METdataio schema to load the TOTAL_DIR column added to the VL1L2, VAL1L2, and VCNT line types during the MET 12.0.0 beta5 development cycle #307

JohnHalleyGotway opened this issue May 21, 2024 · 0 comments · Fixed by #311
Assignees
@bikegeek
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: load Tasks related to the database loading priority: blocker Blocker requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone
METdataio-3.0.0

Comments

@JohnHalleyGotway
Copy link
Contributor

Describe the Enhancement

Issue dtcenter/MET#2395 was reopened for the MET-12.0.0-beta5 development cycle to add a new TOTAL_DIR column to the VL1L2, VAL1L2, and VCNT line types. Pull request dtcenter/MET#2892 incorporates these changes into the develop branch.

Note that this column is added BEFORE the corresponding statistics... in the middle of the line. But that's fine because this schema for MET-12.0.0 has not actually been released yet.

This issue is to update the METdataio loader to update the schema and parse data from these new columns.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues

Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version

  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: load Tasks related to the database loading priority: blocker Blocker requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone labels May 21, 2024
@JohnHalleyGotway JohnHalleyGotway added this to the METdataio-3.0.0 milestone May 21, 2024
@JohnHalleyGotway JohnHalleyGotway changed the title Enhance METdataio schema to handle changes to the VL1L2, VAL1L2, and VCNT line types during the MET 12.0.0 beta5 development cycle Enhance METdataio schema to load the TOTAL_DIR added to the VL1L2, VAL1L2, and VCNT line types during the MET 12.0.0 beta5 development cycle May 21, 2024
@JohnHalleyGotway JohnHalleyGotway changed the title Enhance METdataio schema to load the TOTAL_DIR added to the VL1L2, VAL1L2, and VCNT line types during the MET 12.0.0 beta5 development cycle Enhance METdataio schema to load the TOTAL_DIR column added to the VL1L2, VAL1L2, and VCNT line types during the MET 12.0.0 beta5 development cycle May 21, 2024
This was referenced May 21, 2024
Open
Merged
bikegeek added a commit that referenced this issue Jun 24, 2024
@bikegeek
Issue #307 TOTAL_DIR for VL1L2, VAL1L2, and VCNT linetypes
16504be
bikegeek added a commit that referenced this issue Jun 24, 2024
@bikegeek
Issue #307 added TOTAL_WIND to VL1L2, VAL1L2, and VCNT
911749e
bikegeek added a commit that referenced this issue Jun 25, 2024
@bikegeek
Issue #307 initial commit of test for VL1L2, VAL1L2, and VCNT for the…
75e08b7 
… TOTAL_DIR column
bikegeek added a commit that referenced this issue Jun 25, 2024
@bikegeek
issue #307 config file for tests
b34edec
bikegeek added a commit that referenced this issue Jun 25, 2024
@bikegeek
issue #307 modify setup_db to return the connection object instead of…
307bc97 
… the database settings
bikegeek added a commit that referenced this issue Jun 26, 2024
@bikegeek
Feature 307 schema total dir (#311)
0fafba6 
* Issue #307 TOTAL_DIR for VL1L2, VAL1L2, and VCNT linetypes

* Issue #307 added TOTAL_WIND to VL1L2, VAL1L2, and VCNT

* Issue #307 initial commit of test for VL1L2, VAL1L2, and VCNT for the TOTAL_DIR column

* issue #307 config file for tests

* issue #307 modify setup_db to return the connection object instead of the database settings

* modify setup to return only the database data class

* updated to separate the hostname from the port in the config file and
return the connection object in the setup code

* update to separate the host and port and simplify test setup code

* fix indentation and complete the try-finally block

* add test to check if db is created and fix test for tables test

* added test for presence of the mv_load_test DB

* Added test to check for the total_dir column in the VL1L2, VAL1L2, and VCNT linetype tables

* Clean up extraneous blank lines

* Sample data for testing

---------

Co-authored-by: Minna Win <minnawin@mohawk.rap.ucar.edu>
@bikegeek bikegeek linked a pull request Jun 26, 2024 that will close this issue
Feature 307 schema total dir #311
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bikegeek bikegeek

Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: load Tasks related to the database loading priority: blocker Blocker requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
METplus-Analysis-6.0.0 Development
Status: ✅ Done
Milestone
METdataio-3.0.0
Development

Successfully merging a pull request may close this issue.

Feature 307 schema total dir dtcenter/METdataio
2 participants
@bikegeek @JohnHalleyGotway