Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 307 schema total dir #311

Merged
merged 16 commits into from
Jun 26, 2024
Merged

Feature 307 schema total dir #311

merged 16 commits into from
Jun 26, 2024

Conversation

bikegeek
Copy link
Collaborator

@bikegeek bikegeek commented Jun 26, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

    loaded schema onto 'mohawk' database
    ran tests to check for the total_dir columns in the vl1l2, val1l2, and vcnt tables

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • verify the correctness of the mv_mysql.sql file (METdbLoad/sql)
    
  • verify the correctness of the update_for_6_0_beta5.sql file (METdbLoad/sql/updates)
    
  • any other tests if they affect METexpress
    
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [Yes]

    If yes, please describe: Quality gate fails because of "duplicate" code in the tests.

  • Please complete this pull request review by [as soon as possible for beta5 release for Friday June 29 (latest)].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METdataio-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@bikegeek bikegeek added this to the METdataio-3.0.0 milestone Jun 26, 2024
Copy link
Contributor

@mollybsmith-noaa mollybsmith-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@bikegeek bikegeek merged commit 0fafba6 into develop Jun 26, 2024
8 of 9 checks passed
@bikegeek bikegeek deleted the feature_307_schema_total_dir branch June 26, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
2 participants