Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add columns to line_data_tcmpr table #251 #252

Merged
merged 1 commit into from Dec 21, 2023
Merged

Conversation

TatianaBurek
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

  • rested on mv_wsap_dist database

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@TatianaBurek TatianaBurek added this to the METdataio-3.0.0 milestone Dec 20, 2023
@TatianaBurek TatianaBurek linked an issue Dec 20, 2023 that may be closed by this pull request
23 tasks
@bikegeek bikegeek merged commit 9b361d4 into develop Dec 21, 2023
9 checks passed
@bikegeek bikegeek deleted the issue_251_sql_update branch December 21, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bugfix create an update schema script to add columns to line_data_tcmpr table
2 participants