Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision series for MODE-TD #157

Closed
22 tasks
TatianaBurek opened this issue Oct 4, 2021 · 0 comments · Fixed by #166
Closed
22 tasks

Revision series for MODE-TD #157

TatianaBurek opened this issue Oct 4, 2021 · 0 comments · Fixed by #166
Assignees
Labels
alert: NEED MORE DEFINITION Not yet actionable, additional definition required METplotpy: Plots priority: high High Priority requestor: METplus Team METplus Development Team requestor: NOAA/WPC NOAA Weather Prediction Center type: bug Fix something that is not working

Comments

@TatianaBurek
Copy link
Collaborator

Describe the Problem

MODE-TD Revision box plot is empty. Need to fix it and match the Rscript version.
This is the XML:

plot_20211004_134424.xml.txt

Expected Behavior

Python and Rscript MODE-TD Revision plots should be similar

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.
@TatianaBurek TatianaBurek added type: bug Fix something that is not working priority: high High Priority alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle METplotpy: Plots labels Oct 4, 2021
@TatianaBurek TatianaBurek added this to the METplotpy-1.1 milestone Oct 4, 2021
@TatianaBurek TatianaBurek self-assigned this Oct 4, 2021
@TaraJensen TaraJensen removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Oct 13, 2021
TatianaBurek added a commit that referenced this issue Oct 15, 2021
@TatianaBurek TatianaBurek linked a pull request Nov 2, 2021 that will close this issue
12 tasks
bikegeek pushed a commit that referenced this issue Nov 2, 2021
* mtd_revision #157

* prototype functions for  Revision series for MODE-TD #157

* added showlegend=True to the plot so the legend is always printed #157

* change the series name by adding revision stats if needed #157

* fix handling missing box parameters #157
@bikegeek bikegeek closed this as completed Nov 2, 2021
bikegeek added a commit that referenced this issue Dec 17, 2021
* original version #9

* check if some optional parameter exist before assign them to the variables #9

* fixed the images names for the comparison

* fixed the images names for the comparison

* Migrate issue and PR template changes from PR MET/#1803 into METplotpy develop branch.

* add show_in_browser property to the wind_rose #9

* add show_in_browser property to the wind_rose #9

* remove ./ before the file name #9

* remove stat_input property. Will use provided point_stat_mpr.txt by default #9

* rename the file #9

* by default point to data file in the test dir #9

* add nicenumber and pretty methods that are used in mpr_plot #9

* original version #9

* original version #9

* original version #9

* Update README.md

Added GitHub Discussions info.

* changed non-unicode apostrophe and fixed typo in URL

* add the error message if one of the derived components is a group #79

* move plotting script (and add __init__.py) from METcalcpy repository

* Modifications to automation settings to fail on documentation warnings

* Modifications to automation settings to fail on documentation warnings

* Delete main.yml

* added text

* fixed incorrect issue number for github issue #84

* update the preferences #119

* fixes for the optional properties #119

* updates for METviewer #119

* add indy var to filters #119

* improve the file name for HTML output #119

* initial version

* added mpr_file_list property and the data file to it #115 #9

* change the datatype from string to str #115 #9

* removed mpr_file_list property from the default. It always should be in the user-supplied yaml  #115 #9

* Added build docs file

* initial version #119

* initial version #119

* save points for the each series and indy_val #119

* add box plot documentation file to index.rst  #119

* fixed path to custom_box.yaml  #119

* add references  #119

* reverse x2axis if xaxis_reverse was selected  #119

* check boolean values against True  #119

* committed show_in_browser  #119

* Change the names of the CI data columns from bcl/bcu to btcl/btcu in Reliability plot #124

* Change the names of the CI data columns from bcl/bcu to btcl/btcu in Reliability plot #124

* Use METcalcpy correlation instead of from pingouin library #127

* Initial version of documentation for the mjo plotting provided by NOAA/Maria Gehne.

* Fixed typos that generate warnings

* Fixed typo and added more text

* Added mjo_rmm_omi to toc tree

* Removed incorrect formatting

* do not sort by 'fcst_lead' if it is not in the data columns list #129

* Removed pingouin and bootstrapped requirments as these dependencies have been removed

* Updates for v1.1.0 beta1

* updated for v1.1.0 beta1

* Update version

updated for beta2

* Update version

added the -dev to indicate that the next version is the development version for beta2

* do not sort by 'fcst_lead' if it is not in the data columns list #129

* Added Frequency Plots

* add box.png to be checked

* updated image

* initial version

* initial version #126

* initial version #126

* remove parameters for box

* initial version #126

* initial version #126

* added bar #126

* initial version #126

* Feature 121 develop discussions (#133)

* For #121, removed references to met_help@ucar.edu where an email was listed, and replace with a link to GitHub Discussions where appropriate

* Removed docs/metplotpy_docs.tar

* Add the Python implementation of the ens_ss plot #308

* Add the Python implementation of the ens_ss plot #308

* Add the Python implementation of the ens_ss plot #308

* Add the Python implementation of the ens_ss plot #308

* plot_stat parameter is optional

* close the points file

* fixed the file name

* close the points file

* fixed the file name

* fixed the file name

* close the points file

* close the points file

* Add the Python implementation of the ens_ss plot #308

* fixed path to custom_ens_ss.yaml #308

* Fix stale URL in GitHub issue and pull request templates.

* Delete METLoadEnsemble_NEW.py

No new updates from Mike Erickson (8/11/2021).  Deleting this as requested.

* Delete mtd_retroruns_save_NEWSeTEST.py

Deleted as requested by Mike Erickson (8/11/2021), no update in the 8/11/2021 code.

* Description of latest additions from Mike Erickson

* Update README

* Update README

* Latest from Mike Erickson 8/11/2021

* Latest updates from Mike Erickson NOAA/WPC 8/11/2021

* added methods to plot horizontal and vertical lines #142

* moved series_data attribute to the base class and added a new method to check beta_value #142

* include a method to check beta_value #142

* moved series_data attribute to the base class #142

* moved series_data attribute to the base class #142

* Adding documentation link

* Added additional default labels

* Updates for beta2

* Update for beta2 release

* Fixed formatting errors

* Update release-notes.rst

removed additional line feeds

* Update version

update for beta3 development

* include both  y1/y1 series in min/max range for the axis sync

* remove unused parameter 'list_static_val' #150

* Change ',' as a separator for the series group to ':' #152

* Adding changes necessary for a successful RTD build

* Change the names of the CI data columns from bcl/bcu to btcl/btcu  fot boot #156

* commented out show_in_browser

* Remove the -dev portion of the version number

* Updates for the beta3 release.

* Fix formatting

* Close emphasis command

* update version for next beta development

* added indy_plot_val and create_list_by_plot_val_ordering method to accommodate reordering based on  plot_val values #161

* usr ordered indy values #161

* Update installation.rst

update the version of cartopy from 0.17 to 0.18 (the 0.18 version does NOT cause an overlap of the 180/-180 longitude line when the central longitude is set to 180)

* plots with groups with date values don't get created (#164)

Use regex for parsing #163

* Issue/157 revision mtd (#166)

* mtd_revision #157

* prototype functions for  Revision series for MODE-TD #157

* added showlegend=True to the plot so the legend is always printed #157

* change the series name by adding revision stats if needed #157

* fix handling missing box parameters #157

* Issue/141 histogram (#169)

* make plot_stat optional #141

* Create rhist plot to be used by METviewer #141

* Create rhist plot to be used by METviewer #141

* Create rhist plot to be used by METviewer #141

* initial version #141

* added PHistogramConfig #141

* improve x-axis grid appearance #141

* initial version #141

* initial version #141

* initial version #141

* initial version #141

* initial version #141

* initial version #141

* initial version #141

* Feature 153 intermed files (#168)

* Github Issue #153 intermediary files: provide support for turning on/off the writing of intermediary file used by METviewer by setting dump_points_1 to True or False.

* Github #153 update the comment to reflect what is being overridden

* Github issue #153 fixed incorrect behavior

* Github issue #153 add support for turning on/off the writing of intermediate file used by METviewer by collecting the value of the dump_file_1 setting.

* Github issue #153 overwrite the default config and turn off writing of intermediate file.

* Github Issue #153 revert to original, keep this simple to use all the settings in the default config file.

* Github Issue #153 set the default behavior to write the intermediate file used by METviewer

* Github issue #153 clean up order of options to be consistent with default config and provide support for turning on/off the creating of intermediate file used by METviewer.

* Github Issue #153 support for turning off the writing of the intermediate file used by METviewer

* Github Issue #153 provide support for turning on/off writing intermediate output file used by METviewer

* Github issue #153 by default, turn on the creation of the intermediate file used by METviewer

* needed for running tests

* Needed for imports

* Needed for imports

* Github #153 update config setting

* Github issue #153 update config settings

* Clean up import and cleaning up of output files in between tests

* Github issue #153 by default, set dump_files option to "False"

* Github issue #153 by default, turn off creating intermediate points1 file used by METviewer

* Github issue #153 by default, turn off creating the intermediate .points1 file used by METviewer

* Github Issue #153 override the dump_points setting in the default config and generate the .points1 file used by METviewer

* Github issue #153 turn on the creation of the .points1 file used by METviewer

* Github issue #153 do not request the generation of .points1 file used by METviewer

* Update custom_performance_diagram.yaml

Turn off creation of the .points1 file used by METviewer

* Github Issue #153 Add this so the appropriate modules are imported

* To be consistent with performance diagram, explicitly list what should be imported with roc_diagram

* Github Issue #153 updated assert

* Delete plot_20200317_151252.points1

not needed for tests, this no longer gets generated in the test config file

* Delete test_performance_diagram.py

doesn't work, replacing with new test

* Working version

* test_performance_diagram

working version

* Hint for setting the PYTHONPATH to run the test from the command line

* Update custom_performance_diagram.yaml

set the dump_points_1 to 'False' to prevent creating the .points1 file

* Github Issue #153 Allow user to specify where to save the .points1 file.

* Github Issue #153 support to allow user to specify WHERE to save the points1 file

* Github Issue #153 Support for specifying location for storing the points1 file

* updates to test to reflect support for specifying where intermediate file gets saved

* Github Issue #153 added additional informative comment to the points_path config option

* Github issue #153 support for specifying where the save the points1 file via the points_path configuration setting

* Reorganized lines of code

* updates to test for Issue #153 intermediate files

* Hint for running via command line

* new config files used for testing

* Additional tests for Github issue #153

* uncomment all, now all tests will run

* updated tests for Github issue #153

* Github Issue #153 added support to indicate where to save points1 file-default location if points_path is absent, or user-spceified directory if set

* support for Github issue #153- specify where to save points1 file via points_path config setting (absence indicates saving to default location)

* Github Issue #153 support for indicating where points1 files are to be saved via points_path config option

* Github Issue #153 changed regex to support file input, reorganized code

* Github Issue #153 additional test code and configs, code cleanup

* use os.rmdir to remove temp directory created during testing

* use os.rmdir to remove subdir created during testing

* Github Issue #153 additional config and test

* Github Issue #153 support for the optional setting points_path, which indicates where to store the points1 intermediate file

* fixed comment for class name info

* add import to import the GROUP_SEPARATOR (which is defined in the __init__.py file for the METplotpy plots package)

* Github Issue #153 support for optional points_path to indicate where to save the points1 files outside of its default location

* use to compare all plots against

* Github issue #153 updates to tests and config files

* Github Issue #153 support for optional points_path config setting

* Github Issue #153 updates to config and tests

* Github Issue #153 support for the optional points_path configuration setting

* Remove temporary subdirs

* Github Issue #153 updates to testing and configs

* Github Issue #153 support for optional points_path

* Github Issue #153 update documentation for ROC diagram so users with limited file/directory permissions can run in their environment.

* remove the 'hello' hidden in the page

* fixed incorrect path to config file in literalincludes

* Cleaned up some formatting and wording

* fixed errors in directory name

* fix more instructions

* fix more errors

* fix more errors

* fix line 75?

* fix line 124?

* fixed incorrect config file names in instructions

* Github Issue #153 move config files from plots/roc_diagram to test/roc_diagram to be consistent with other plots and to maintain only one copy of config files and sample data

* moved data and config files to test/roc_diagram, instructions updated to reflect this

* fix some directory instructions that didn't get updated

* fixed another directory path

* fixed yet another directory path

* simplify directory for user space

* Need a minimal config file for instructions in the Users Guide

* Still finding out of date directory paths

* Github issue #153 moved sample data to the test/roc_diagram directory

* updates after verifying instructions are correct

* many updates, instructions should be correct

* replace previous version with this version, which has more comments

* moved from the source code to here to be consistent with other plots

* comment out image comparison, fails if you change hosts/OS type

* Delete custom_performance_diagram.yaml

moved to test/performance_diagram to be consistent with other plots and to keep this directory clean

* Delete minimal_performance_diagram.yaml

moved to test/performance_diagram to be consistent with other plots and to keep this directory clean

* Delete plot_20200317_151252.data

moved to test/performance_diagram to be consistent with other plots and to keep this directory clean

* Delete README.rst

redundant- there is now up-to-date documentation on readthedocs.io

* to enable importing this module

* removed WORKING_DIR sentence that was unnecessary

* corrected the relative path for the ROC data

* remove redundant entry

* updates to reflect instructions so all users can follow, regardless of their permissions

* updates to wording to be more concise with respect to saving intermediate files

* plots that were missing from the original documentation

* replace roc with performance diagram (cut-and-paste error)

* Updates to reflect requested changes from PR#168

* Address incorrect formatting of the last bullet point on the page

* fix errors with bullets

* fix errors with bullets

* more additions from documentation requests related to PR #168

* fix formatting for bold text

* removed unneccessary instructions for the stat_input in the default config file

* add default plot image

* fixed typo in instructions

* Add instructions for setting METPLOTPY_BASE

* latest updates

* added cleanup and updated to match documentation

* some temp files weren't getting cleaned up, now cleanup is working

* Delete test_custom_line.yaml

No longer in use

* updates, clean-up

* Delete line.points1

this is output from files, should not be part of test code

* Delete line.points2

created as output from tests, should not be part of source

* initial commit

* removed unused, out of date files

* README is out of date, only maintain the read the docs documentation

* Move data to the test/line directory

* moved from the metplotpy/plots/line directory

* updates to make tests consistent across all plots

* updated for new location of data

* additional test

* fixed broken tests

* remove irrelevant section

* updated paths for file includes

* updates and new plot added

* moved the minimal config file (simple_box.yaml) to test dir, fixed cleaning up of temp files

* additional comments

* additional comments

* additional comments

* additional comments

* moved from plots/box directory

* correction to default file description

* added missing default settings

* updates and added default plot image

* fixed rst syntax

* clean up points file

* fixed inconsistencies

* updates for #153

* fixed copy-and-paste errors

* updates to instructions

* fixed typo

* fix rst syntax

* still had rst syntax error

* still had rst syntax error about bullet list

* added yaml as requirement

* fixed copy and paste error (from bar plot)

* Fixed package import location line, added text to the help message and
commented out the view on website command

* Update custom_bar.yaml

added points_path (currently commented out)

* Update custom_box.yaml

added points_path (uncommented)

* Update custom_ens_ss.yaml

added points_path (uncommented)

* correct the comment to the test fixture to match with the test

* Github Issue #153 add points_path setting to the configuration files

* Github #153 updates to the histogram_2d plot

* Delete grid_diag_temperature.nc

moved to the test/histogram_2d directory

* issue #153 refactored to be consistent with other DTC generated plot type behavior, added stub for indicating where to store dump_points_1 points file (when this plot gets incorporated into METviewer)

* files needed for testing and for user instructions

* cleaned up comments

* updates to minimal config file so it is ready for running tests

* no tests are run, the minimal_histogram_2d.yaml file must have explicit paths defined for stat_input and plot_filename to run correctly

Co-authored-by: Hank Fisher <fisherh@seneca.rap.ucar.edu>

* Github #175 create beta4 release

* Update release-notes.rst

hopefully fix the bullet lists that don't end with a blank line

* update the release date

* updates for beta4 release

* removed the -dev tag

* cleaned up formatting to be consistent with previous releases

* Update release-notes.rst

added the missing enhancement for issue #153 (must have been inadvertently deleted when cleaning up formatting)

Co-authored-by: TatianaBurek <tatiana@ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: Minna Win <minnawin@kiowa.rap.ucar.edu>
Co-authored-by: Hank Fisher <fisherh@ucar.edu>
Co-authored-by: Christina Kalb <kalb@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Co-authored-by: Hank Fisher <fisherh@seneca.rap.ucar.edu>
@TaraJensen TaraJensen added requestor: METplus Team METplus Development Team requestor: NOAA/WPC NOAA Weather Prediction Center labels Jan 3, 2022
bikegeek added a commit that referenced this issue Jan 13, 2022
* Migrate issue and PR template changes from PR MET/#1803 into METplotpy main_v1.0 branch.

* Update README.md

Added GitHub Discussions info

* changed non-unicode apostrophe and fixed typo in URL

* Feature 121 main v1.0 discussions (#134)

* For #121, removed references to met_help@ucar.edu where an email was listed, and replace with a link to GitHub Discussions where appropriate

* Removed docs/metplotpy_docs.tar

* Fix stale URL in GitHub issue and pull request templates.

* Updated release version and date

* Added documentation link

* Github Issue #37 Added by_pressure_lvl option to indicate whether to plot range vs pressure in mb or range vs height (if not set).  Pressure in height (meters) assumes that the user is using the output from the METcalcpy vertical interpolation module.

* Github Issue #37 First working modification to support plotting of both tangential and radial wind cross-section plots and support for either plotting by pressure (mb) or height (m).

* Update issue templates

Added new default labels

* More instructive comment on how to use by_pressure_lvl

* minimizing amount of duplicated code.

* moved azimuthal mean calculations outside of loop

* Adding changes necessary for a successful RTD build

* Github #37.  Return the radial tangential wind data dictionary that contains radial and tangential wind information

* Github #37 Remove the --by-pressure-level argument and instead utilize the value of the vertical_coord_type_in in the plot_cross_section.yaml config file.

* Github #37.  Initial commit of the YAML config file for configuring the vertical levels of the radial and tangential winds, either by level or pressure.

* Github #37 Remove argument for pressure level and instead use values from the plot_cross_section.yaml config file to configure the y-tick labels for the plots.

* Github #37 added support to config to set contour levels for the tangential and radial wind contour plots.

* first draft, needs more content

* Added tcrmw_cross_section to TOC

* updated link to data, more content to description section

* Renaming original plot cross section.

* Renamed original yaml test file.

* Start on brand new plot cross section script, that should work with output of vertical_interp.

* Redo of YAML.

* plot appearance customizations support

* updated y-axis limits

* changes made to address pylint warnings

* made more generic to match with user documentation instructions

* correted x-label to 'units or RMW' and added support for indicating time slice of interest

* added yaml as requirement

* work in progress, removed the instructions for creating the pressure level plots

* work in progress, point to feature_34 branch of METcalcpy for instructions

* sample tcrmw vertical level plot for temperature

* completed instructions for generating tcrmw cross-section plot for temperature

* fixed typo, replaced ',,' with ','

* removed unneccessary text, reformatted

* Update index.rst

removed unnecessary 'hello'

* remove link to input data used by METcalcpy to avoid confusion

* Feature 175 v1.1.0 beta4 (#176)

* original version #9

* check if some optional parameter exist before assign them to the variables #9

* fixed the images names for the comparison

* fixed the images names for the comparison

* Migrate issue and PR template changes from PR MET/#1803 into METplotpy develop branch.

* add show_in_browser property to the wind_rose #9

* add show_in_browser property to the wind_rose #9

* remove ./ before the file name #9

* remove stat_input property. Will use provided point_stat_mpr.txt by default #9

* rename the file #9

* by default point to data file in the test dir #9

* add nicenumber and pretty methods that are used in mpr_plot #9

* original version #9

* original version #9

* original version #9

* Update README.md

Added GitHub Discussions info.

* changed non-unicode apostrophe and fixed typo in URL

* add the error message if one of the derived components is a group #79

* move plotting script (and add __init__.py) from METcalcpy repository

* Modifications to automation settings to fail on documentation warnings

* Modifications to automation settings to fail on documentation warnings

* Delete main.yml

* added text

* fixed incorrect issue number for github issue #84

* update the preferences #119

* fixes for the optional properties #119

* updates for METviewer #119

* add indy var to filters #119

* improve the file name for HTML output #119

* initial version

* added mpr_file_list property and the data file to it #115 #9

* change the datatype from string to str #115 #9

* removed mpr_file_list property from the default. It always should be in the user-supplied yaml  #115 #9

* Added build docs file

* initial version #119

* initial version #119

* save points for the each series and indy_val #119

* add box plot documentation file to index.rst  #119

* fixed path to custom_box.yaml  #119

* add references  #119

* reverse x2axis if xaxis_reverse was selected  #119

* check boolean values against True  #119

* committed show_in_browser  #119

* Change the names of the CI data columns from bcl/bcu to btcl/btcu in Reliability plot #124

* Change the names of the CI data columns from bcl/bcu to btcl/btcu in Reliability plot #124

* Use METcalcpy correlation instead of from pingouin library #127

* Initial version of documentation for the mjo plotting provided by NOAA/Maria Gehne.

* Fixed typos that generate warnings

* Fixed typo and added more text

* Added mjo_rmm_omi to toc tree

* Removed incorrect formatting

* do not sort by 'fcst_lead' if it is not in the data columns list #129

* Removed pingouin and bootstrapped requirments as these dependencies have been removed

* Updates for v1.1.0 beta1

* updated for v1.1.0 beta1

* Update version

updated for beta2

* Update version

added the -dev to indicate that the next version is the development version for beta2

* do not sort by 'fcst_lead' if it is not in the data columns list #129

* Added Frequency Plots

* add box.png to be checked

* updated image

* initial version

* initial version #126

* initial version #126

* remove parameters for box

* initial version #126

* initial version #126

* added bar #126

* initial version #126

* Feature 121 develop discussions (#133)

* For #121, removed references to met_help@ucar.edu where an email was listed, and replace with a link to GitHub Discussions where appropriate

* Removed docs/metplotpy_docs.tar

* Add the Python implementation of the ens_ss plot #308

* Add the Python implementation of the ens_ss plot #308

* Add the Python implementation of the ens_ss plot #308

* Add the Python implementation of the ens_ss plot #308

* plot_stat parameter is optional

* close the points file

* fixed the file name

* close the points file

* fixed the file name

* fixed the file name

* close the points file

* close the points file

* Add the Python implementation of the ens_ss plot #308

* fixed path to custom_ens_ss.yaml #308

* Fix stale URL in GitHub issue and pull request templates.

* Delete METLoadEnsemble_NEW.py

No new updates from Mike Erickson (8/11/2021).  Deleting this as requested.

* Delete mtd_retroruns_save_NEWSeTEST.py

Deleted as requested by Mike Erickson (8/11/2021), no update in the 8/11/2021 code.

* Description of latest additions from Mike Erickson

* Update README

* Update README

* Latest from Mike Erickson 8/11/2021

* Latest updates from Mike Erickson NOAA/WPC 8/11/2021

* added methods to plot horizontal and vertical lines #142

* moved series_data attribute to the base class and added a new method to check beta_value #142

* include a method to check beta_value #142

* moved series_data attribute to the base class #142

* moved series_data attribute to the base class #142

* Adding documentation link

* Added additional default labels

* Updates for beta2

* Update for beta2 release

* Fixed formatting errors

* Update release-notes.rst

removed additional line feeds

* Update version

update for beta3 development

* include both  y1/y1 series in min/max range for the axis sync

* remove unused parameter 'list_static_val' #150

* Change ',' as a separator for the series group to ':' #152

* Adding changes necessary for a successful RTD build

* Change the names of the CI data columns from bcl/bcu to btcl/btcu  fot boot #156

* commented out show_in_browser

* Remove the -dev portion of the version number

* Updates for the beta3 release.

* Fix formatting

* Close emphasis command

* update version for next beta development

* added indy_plot_val and create_list_by_plot_val_ordering method to accommodate reordering based on  plot_val values #161

* usr ordered indy values #161

* Update installation.rst

update the version of cartopy from 0.17 to 0.18 (the 0.18 version does NOT cause an overlap of the 180/-180 longitude line when the central longitude is set to 180)

* plots with groups with date values don't get created (#164)

Use regex for parsing #163

* Issue/157 revision mtd (#166)

* mtd_revision #157

* prototype functions for  Revision series for MODE-TD #157

* added showlegend=True to the plot so the legend is always printed #157

* change the series name by adding revision stats if needed #157

* fix handling missing box parameters #157

* Issue/141 histogram (#169)

* make plot_stat optional #141

* Create rhist plot to be used by METviewer #141

* Create rhist plot to be used by METviewer #141

* Create rhist plot to be used by METviewer #141

* initial version #141

* added PHistogramConfig #141

* improve x-axis grid appearance #141

* initial version #141

* initial version #141

* initial version #141

* initial version #141

* initial version #141

* initial version #141

* initial version #141

* Feature 153 intermed files (#168)

* Github Issue #153 intermediary files: provide support for turning on/off the writing of intermediary file used by METviewer by setting dump_points_1 to True or False.

* Github #153 update the comment to reflect what is being overridden

* Github issue #153 fixed incorrect behavior

* Github issue #153 add support for turning on/off the writing of intermediate file used by METviewer by collecting the value of the dump_file_1 setting.

* Github issue #153 overwrite the default config and turn off writing of intermediate file.

* Github Issue #153 revert to original, keep this simple to use all the settings in the default config file.

* Github Issue #153 set the default behavior to write the intermediate file used by METviewer

* Github issue #153 clean up order of options to be consistent with default config and provide support for turning on/off the creating of intermediate file used by METviewer.

* Github Issue #153 support for turning off the writing of the intermediate file used by METviewer

* Github Issue #153 provide support for turning on/off writing intermediate output file used by METviewer

* Github issue #153 by default, turn on the creation of the intermediate file used by METviewer

* needed for running tests

* Needed for imports

* Needed for imports

* Github #153 update config setting

* Github issue #153 update config settings

* Clean up import and cleaning up of output files in between tests

* Github issue #153 by default, set dump_files option to "False"

* Github issue #153 by default, turn off creating intermediate points1 file used by METviewer

* Github issue #153 by default, turn off creating the intermediate .points1 file used by METviewer

* Github Issue #153 override the dump_points setting in the default config and generate the .points1 file used by METviewer

* Github issue #153 turn on the creation of the .points1 file used by METviewer

* Github issue #153 do not request the generation of .points1 file used by METviewer

* Update custom_performance_diagram.yaml

Turn off creation of the .points1 file used by METviewer

* Github Issue #153 Add this so the appropriate modules are imported

* To be consistent with performance diagram, explicitly list what should be imported with roc_diagram

* Github Issue #153 updated assert

* Delete plot_20200317_151252.points1

not needed for tests, this no longer gets generated in the test config file

* Delete test_performance_diagram.py

doesn't work, replacing with new test

* Working version

* test_performance_diagram

working version

* Hint for setting the PYTHONPATH to run the test from the command line

* Update custom_performance_diagram.yaml

set the dump_points_1 to 'False' to prevent creating the .points1 file

* Github Issue #153 Allow user to specify where to save the .points1 file.

* Github Issue #153 support to allow user to specify WHERE to save the points1 file

* Github Issue #153 Support for specifying location for storing the points1 file

* updates to test to reflect support for specifying where intermediate file gets saved

* Github Issue #153 added additional informative comment to the points_path config option

* Github issue #153 support for specifying where the save the points1 file via the points_path configuration setting

* Reorganized lines of code

* updates to test for Issue #153 intermediate files

* Hint for running via command line

* new config files used for testing

* Additional tests for Github issue #153

* uncomment all, now all tests will run

* updated tests for Github issue #153

* Github Issue #153 added support to indicate where to save points1 file-default location if points_path is absent, or user-spceified directory if set

* support for Github issue #153- specify where to save points1 file via points_path config setting (absence indicates saving to default location)

* Github Issue #153 support for indicating where points1 files are to be saved via points_path config option

* Github Issue #153 changed regex to support file input, reorganized code

* Github Issue #153 additional test code and configs, code cleanup

* use os.rmdir to remove temp directory created during testing

* use os.rmdir to remove subdir created during testing

* Github Issue #153 additional config and test

* Github Issue #153 support for the optional setting points_path, which indicates where to store the points1 intermediate file

* fixed comment for class name info

* add import to import the GROUP_SEPARATOR (which is defined in the __init__.py file for the METplotpy plots package)

* Github Issue #153 support for optional points_path to indicate where to save the points1 files outside of its default location

* use to compare all plots against

* Github issue #153 updates to tests and config files

* Github Issue #153 support for optional points_path config setting

* Github Issue #153 updates to config and tests

* Github Issue #153 support for the optional points_path configuration setting

* Remove temporary subdirs

* Github Issue #153 updates to testing and configs

* Github Issue #153 support for optional points_path

* Github Issue #153 update documentation for ROC diagram so users with limited file/directory permissions can run in their environment.

* remove the 'hello' hidden in the page

* fixed incorrect path to config file in literalincludes

* Cleaned up some formatting and wording

* fixed errors in directory name

* fix more instructions

* fix more errors

* fix more errors

* fix line 75?

* fix line 124?

* fixed incorrect config file names in instructions

* Github Issue #153 move config files from plots/roc_diagram to test/roc_diagram to be consistent with other plots and to maintain only one copy of config files and sample data

* moved data and config files to test/roc_diagram, instructions updated to reflect this

* fix some directory instructions that didn't get updated

* fixed another directory path

* fixed yet another directory path

* simplify directory for user space

* Need a minimal config file for instructions in the Users Guide

* Still finding out of date directory paths

* Github issue #153 moved sample data to the test/roc_diagram directory

* updates after verifying instructions are correct

* many updates, instructions should be correct

* replace previous version with this version, which has more comments

* moved from the source code to here to be consistent with other plots

* comment out image comparison, fails if you change hosts/OS type

* Delete custom_performance_diagram.yaml

moved to test/performance_diagram to be consistent with other plots and to keep this directory clean

* Delete minimal_performance_diagram.yaml

moved to test/performance_diagram to be consistent with other plots and to keep this directory clean

* Delete plot_20200317_151252.data

moved to test/performance_diagram to be consistent with other plots and to keep this directory clean

* Delete README.rst

redundant- there is now up-to-date documentation on readthedocs.io

* to enable importing this module

* removed WORKING_DIR sentence that was unnecessary

* corrected the relative path for the ROC data

* remove redundant entry

* updates to reflect instructions so all users can follow, regardless of their permissions

* updates to wording to be more concise with respect to saving intermediate files

* plots that were missing from the original documentation

* replace roc with performance diagram (cut-and-paste error)

* Updates to reflect requested changes from PR#168

* Address incorrect formatting of the last bullet point on the page

* fix errors with bullets

* fix errors with bullets

* more additions from documentation requests related to PR #168

* fix formatting for bold text

* removed unneccessary instructions for the stat_input in the default config file

* add default plot image

* fixed typo in instructions

* Add instructions for setting METPLOTPY_BASE

* latest updates

* added cleanup and updated to match documentation

* some temp files weren't getting cleaned up, now cleanup is working

* Delete test_custom_line.yaml

No longer in use

* updates, clean-up

* Delete line.points1

this is output from files, should not be part of test code

* Delete line.points2

created as output from tests, should not be part of source

* initial commit

* removed unused, out of date files

* README is out of date, only maintain the read the docs documentation

* Move data to the test/line directory

* moved from the metplotpy/plots/line directory

* updates to make tests consistent across all plots

* updated for new location of data

* additional test

* fixed broken tests

* remove irrelevant section

* updated paths for file includes

* updates and new plot added

* moved the minimal config file (simple_box.yaml) to test dir, fixed cleaning up of temp files

* additional comments

* additional comments

* additional comments

* additional comments

* moved from plots/box directory

* correction to default file description

* added missing default settings

* updates and added default plot image

* fixed rst syntax

* clean up points file

* fixed inconsistencies

* updates for #153

* fixed copy-and-paste errors

* updates to instructions

* fixed typo

* fix rst syntax

* still had rst syntax error

* still had rst syntax error about bullet list

* added yaml as requirement

* fixed copy and paste error (from bar plot)

* Fixed package import location line, added text to the help message and
commented out the view on website command

* Update custom_bar.yaml

added points_path (currently commented out)

* Update custom_box.yaml

added points_path (uncommented)

* Update custom_ens_ss.yaml

added points_path (uncommented)

* correct the comment to the test fixture to match with the test

* Github Issue #153 add points_path setting to the configuration files

* Github #153 updates to the histogram_2d plot

* Delete grid_diag_temperature.nc

moved to the test/histogram_2d directory

* issue #153 refactored to be consistent with other DTC generated plot type behavior, added stub for indicating where to store dump_points_1 points file (when this plot gets incorporated into METviewer)

* files needed for testing and for user instructions

* cleaned up comments

* updates to minimal config file so it is ready for running tests

* no tests are run, the minimal_histogram_2d.yaml file must have explicit paths defined for stat_input and plot_filename to run correctly

Co-authored-by: Hank Fisher <fisherh@seneca.rap.ucar.edu>

* Github #175 create beta4 release

* Update release-notes.rst

hopefully fix the bullet lists that don't end with a blank line

* update the release date

* updates for beta4 release

* removed the -dev tag

* cleaned up formatting to be consistent with previous releases

* Update release-notes.rst

added the missing enhancement for issue #153 (must have been inadvertently deleted when cleaning up formatting)

Co-authored-by: TatianaBurek <tatiana@ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: Minna Win <minnawin@kiowa.rap.ucar.edu>
Co-authored-by: Hank Fisher <fisherh@ucar.edu>
Co-authored-by: Christina Kalb <kalb@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Co-authored-by: Hank Fisher <fisherh@seneca.rap.ucar.edu>

* Revert "Feature 175 v1.1.0 beta4 (#176)" (#177)

This reverts commit b147990.

* Update reliability_diagram.rst

fixed path to the custom_reliability_use_defaults.yaml config file

* Update reliability_diagram.rst

fixed incorrect directory path to the custom_reliability_use_defaults.yaml (path is relative to the docs directory)

* Update reliability_diagram.rst

reverting back to previous changes.

* use create_permutations instead of create_permutations_mv (which has been modified in a different Github issue).

* updated output directory to match host-kiowa

Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Co-authored-by: David Fillmore <davidfillmore@Davids-MacBook-Air.local>
Co-authored-by: TatianaBurek <tatiana@ucar.edu>
Co-authored-by: Minna Win <minnawin@kiowa.rap.ucar.edu>
Co-authored-by: Hank Fisher <fisherh@ucar.edu>
Co-authored-by: Christina Kalb <kalb@ucar.edu>
Co-authored-by: Hank Fisher <fisherh@seneca.rap.ucar.edu>
bikegeek added a commit that referenced this issue Sep 7, 2022
* Migrate issue and PR template changes from PR MET/#1803 into METplotpy main_v1.0 branch.

* Update README.md

Added GitHub Discussions info

* changed non-unicode apostrophe and fixed typo in URL

* Feature 121 main v1.0 discussions (#134)

* For #121, removed references to met_help@ucar.edu where an email was listed, and replace with a link to GitHub Discussions where appropriate

* Removed docs/metplotpy_docs.tar

* Fix stale URL in GitHub issue and pull request templates.

* Updated release version and date

* Added documentation link

* Update issue templates

Added new default labels

* Initial directory checkin

* copied plan view and vertical profile scripts to local git branch

* Adding changes necessary for a successful RTD build

* read_fv3_history.py does more than just read

* Removed "read" from name

* update arg s in plt.annotate to text

* Use xarray.plot.pcolormesh

No more computing lat/lon increments.

Make shp argument a directory name not a file name.

Let xarray do colorbar.

LambertConformal not working yet.

* dictionary of tendencies for each state variable

* Put tendency dict in fv3.py

Rename tquv state_variable.

Calculate area of unmasked region.

Assign dstate_variable and resid to DataSet so it all can be plotted in one line.

TODO: put markers on dstate_variable and resid lines in axes and legend.

* define state_variables array

* put st4.pts_in_shp in fv3 module

* use fv3.pts_in_shp, not st4.pts_in_shp

* Reassign correct long_name attrs.

assign latt and lont to fv3ds before splitting out all_tend.

Don't bother adding resid, state_variable, and dstate_variable to "tendency" axis of all_tend,
as in fv3_vert_profile.py.

* Reassign long_name with "tendency" changed to "change"

after multiplying tendency by time

* Remove TODO comment about preserving long_names

* Use __name__ == "__main__" idiom

Trim du3dt from variable names.

Add state_variable to name of tendency dimension (for nice legend title).

Add special symbol to residual and dstate_variable lines, both on line and in legend.

Make residual an option. Sometimes it is so big it swamps all other terms.

Cosmetic changes to fine print.

* use .geoms in shapely iteration

* Reorder mandatory args.

Now start with state variable (tmp, ugrd, etc.),
followed by tendency type (mp, etc)

tendency type can be empty string "" or d{state_variable} or "resid"

encapsulate parse_args and main()

Remove extent

If shp is used for mask, drop masked coordinates so extent is automatically zoomed in.

* rename state variable argument

* history to planview

* fixed lambert conformal projection\n\nadded transform=ccrs.PlateCarree() to DataArray.plot.pcolormesh

* comment about dimension of facetview

* Feature 175 v1.1.0 beta4 (#176)

* original version #9

* check if some optional parameter exist before assign them to the variables #9

* fixed the images names for the comparison

* fixed the images names for the comparison

* Migrate issue and PR template changes from PR MET/#1803 into METplotpy develop branch.

* add show_in_browser property to the wind_rose #9

* add show_in_browser property to the wind_rose #9

* remove ./ before the file name #9

* remove stat_input property. Will use provided point_stat_mpr.txt by default #9

* rename the file #9

* by default point to data file in the test dir #9

* add nicenumber and pretty methods that are used in mpr_plot #9

* original version #9

* original version #9

* original version #9

* Update README.md

Added GitHub Discussions info.

* changed non-unicode apostrophe and fixed typo in URL

* add the error message if one of the derived components is a group #79

* move plotting script (and add __init__.py) from METcalcpy repository

* Modifications to automation settings to fail on documentation warnings

* Modifications to automation settings to fail on documentation warnings

* Delete main.yml

* added text

* fixed incorrect issue number for github issue #84

* update the preferences #119

* fixes for the optional properties #119

* updates for METviewer #119

* add indy var to filters #119

* improve the file name for HTML output #119

* initial version

* added mpr_file_list property and the data file to it #115 #9

* change the datatype from string to str #115 #9

* removed mpr_file_list property from the default. It always should be in the user-supplied yaml  #115 #9

* Added build docs file

* initial version #119

* initial version #119

* save points for the each series and indy_val #119

* add box plot documentation file to index.rst  #119

* fixed path to custom_box.yaml  #119

* add references  #119

* reverse x2axis if xaxis_reverse was selected  #119

* check boolean values against True  #119

* committed show_in_browser  #119

* Change the names of the CI data columns from bcl/bcu to btcl/btcu in Reliability plot #124

* Change the names of the CI data columns from bcl/bcu to btcl/btcu in Reliability plot #124

* Use METcalcpy correlation instead of from pingouin library #127

* Initial version of documentation for the mjo plotting provided by NOAA/Maria Gehne.

* Fixed typos that generate warnings

* Fixed typo and added more text

* Added mjo_rmm_omi to toc tree

* Removed incorrect formatting

* do not sort by 'fcst_lead' if it is not in the data columns list #129

* Removed pingouin and bootstrapped requirments as these dependencies have been removed

* Updates for v1.1.0 beta1

* updated for v1.1.0 beta1

* Update version

updated for beta2

* Update version

added the -dev to indicate that the next version is the development version for beta2

* do not sort by 'fcst_lead' if it is not in the data columns list #129

* Added Frequency Plots

* add box.png to be checked

* updated image

* initial version

* initial version #126

* initial version #126

* remove parameters for box

* initial version #126

* initial version #126

* added bar #126

* initial version #126

* Feature 121 develop discussions (#133)

* For #121, removed references to met_help@ucar.edu where an email was listed, and replace with a link to GitHub Discussions where appropriate

* Removed docs/metplotpy_docs.tar

* Add the Python implementation of the ens_ss plot #308

* Add the Python implementation of the ens_ss plot #308

* Add the Python implementation of the ens_ss plot #308

* Add the Python implementation of the ens_ss plot #308

* plot_stat parameter is optional

* close the points file

* fixed the file name

* close the points file

* fixed the file name

* fixed the file name

* close the points file

* close the points file

* Add the Python implementation of the ens_ss plot #308

* fixed path to custom_ens_ss.yaml #308

* Fix stale URL in GitHub issue and pull request templates.

* Delete METLoadEnsemble_NEW.py

No new updates from Mike Erickson (8/11/2021).  Deleting this as requested.

* Delete mtd_retroruns_save_NEWSeTEST.py

Deleted as requested by Mike Erickson (8/11/2021), no update in the 8/11/2021 code.

* Description of latest additions from Mike Erickson

* Update README

* Update README

* Latest from Mike Erickson 8/11/2021

* Latest updates from Mike Erickson NOAA/WPC 8/11/2021

* added methods to plot horizontal and vertical lines #142

* moved series_data attribute to the base class and added a new method to check beta_value #142

* include a method to check beta_value #142

* moved series_data attribute to the base class #142

* moved series_data attribute to the base class #142

* Adding documentation link

* Added additional default labels

* Updates for beta2

* Update for beta2 release

* Fixed formatting errors

* Update release-notes.rst

removed additional line feeds

* Update version

update for beta3 development

* include both  y1/y1 series in min/max range for the axis sync

* remove unused parameter 'list_static_val' #150

* Change ',' as a separator for the series group to ':' #152

* Adding changes necessary for a successful RTD build

* Change the names of the CI data columns from bcl/bcu to btcl/btcu  fot boot #156

* commented out show_in_browser

* Remove the -dev portion of the version number

* Updates for the beta3 release.

* Fix formatting

* Close emphasis command

* update version for next beta development

* added indy_plot_val and create_list_by_plot_val_ordering method to accommodate reordering based on  plot_val values #161

* usr ordered indy values #161

* Update installation.rst

update the version of cartopy from 0.17 to 0.18 (the 0.18 version does NOT cause an overlap of the 180/-180 longitude line when the central longitude is set to 180)

* plots with groups with date values don't get created (#164)

Use regex for parsing #163

* Issue/157 revision mtd (#166)

* mtd_revision #157

* prototype functions for  Revision series for MODE-TD #157

* added showlegend=True to the plot so the legend is always printed #157

* change the series name by adding revision stats if needed #157

* fix handling missing box parameters #157

* Issue/141 histogram (#169)

* make plot_stat optional #141

* Create rhist plot to be used by METviewer #141

* Create rhist plot to be used by METviewer #141

* Create rhist plot to be used by METviewer #141

* initial version #141

* added PHistogramConfig #141

* improve x-axis grid appearance #141

* initial version #141

* initial version #141

* initial version #141

* initial version #141

* initial version #141

* initial version #141

* initial version #141

* Feature 153 intermed files (#168)

* Github Issue #153 intermediary files: provide support for turning on/off the writing of intermediary file used by METviewer by setting dump_points_1 to True or False.

* Github #153 update the comment to reflect what is being overridden

* Github issue #153 fixed incorrect behavior

* Github issue #153 add support for turning on/off the writing of intermediate file used by METviewer by collecting the value of the dump_file_1 setting.

* Github issue #153 overwrite the default config and turn off writing of intermediate file.

* Github Issue #153 revert to original, keep this simple to use all the settings in the default config file.

* Github Issue #153 set the default behavior to write the intermediate file used by METviewer

* Github issue #153 clean up order of options to be consistent with default config and provide support for turning on/off the creating of intermediate file used by METviewer.

* Github Issue #153 support for turning off the writing of the intermediate file used by METviewer

* Github Issue #153 provide support for turning on/off writing intermediate output file used by METviewer

* Github issue #153 by default, turn on the creation of the intermediate file used by METviewer

* needed for running tests

* Needed for imports

* Needed for imports

* Github #153 update config setting

* Github issue #153 update config settings

* Clean up import and cleaning up of output files in between tests

* Github issue #153 by default, set dump_files option to "False"

* Github issue #153 by default, turn off creating intermediate points1 file used by METviewer

* Github issue #153 by default, turn off creating the intermediate .points1 file used by METviewer

* Github Issue #153 override the dump_points setting in the default config and generate the .points1 file used by METviewer

* Github issue #153 turn on the creation of the .points1 file used by METviewer

* Github issue #153 do not request the generation of .points1 file used by METviewer

* Update custom_performance_diagram.yaml

Turn off creation of the .points1 file used by METviewer

* Github Issue #153 Add this so the appropriate modules are imported

* To be consistent with performance diagram, explicitly list what should be imported with roc_diagram

* Github Issue #153 updated assert

* Delete plot_20200317_151252.points1

not needed for tests, this no longer gets generated in the test config file

* Delete test_performance_diagram.py

doesn't work, replacing with new test

* Working version

* test_performance_diagram

working version

* Hint for setting the PYTHONPATH to run the test from the command line

* Update custom_performance_diagram.yaml

set the dump_points_1 to 'False' to prevent creating the .points1 file

* Github Issue #153 Allow user to specify where to save the .points1 file.

* Github Issue #153 support to allow user to specify WHERE to save the points1 file

* Github Issue #153 Support for specifying location for storing the points1 file

* updates to test to reflect support for specifying where intermediate file gets saved

* Github Issue #153 added additional informative comment to the points_path config option

* Github issue #153 support for specifying where the save the points1 file via the points_path configuration setting

* Reorganized lines of code

* updates to test for Issue #153 intermediate files

* Hint for running via command line

* new config files used for testing

* Additional tests for Github issue #153

* uncomment all, now all tests will run

* updated tests for Github issue #153

* Github Issue #153 added support to indicate where to save points1 file-default location if points_path is absent, or user-spceified directory if set

* support for Github issue #153- specify where to save points1 file via points_path config setting (absence indicates saving to default location)

* Github Issue #153 support for indicating where points1 files are to be saved via points_path config option

* Github Issue #153 changed regex to support file input, reorganized code

* Github Issue #153 additional test code and configs, code cleanup

* use os.rmdir to remove temp directory created during testing

* use os.rmdir to remove subdir created during testing

* Github Issue #153 additional config and test

* Github Issue #153 support for the optional setting points_path, which indicates where to store the points1 intermediate file

* fixed comment for class name info

* add import to import the GROUP_SEPARATOR (which is defined in the __init__.py file for the METplotpy plots package)

* Github Issue #153 support for optional points_path to indicate where to save the points1 files outside of its default location

* use to compare all plots against

* Github issue #153 updates to tests and config files

* Github Issue #153 support for optional points_path config setting

* Github Issue #153 updates to config and tests

* Github Issue #153 support for the optional points_path configuration setting

* Remove temporary subdirs

* Github Issue #153 updates to testing and configs

* Github Issue #153 support for optional points_path

* Github Issue #153 update documentation for ROC diagram so users with limited file/directory permissions can run in their environment.

* remove the 'hello' hidden in the page

* fixed incorrect path to config file in literalincludes

* Cleaned up some formatting and wording

* fixed errors in directory name

* fix more instructions

* fix more errors

* fix more errors

* fix line 75?

* fix line 124?

* fixed incorrect config file names in instructions

* Github Issue #153 move config files from plots/roc_diagram to test/roc_diagram to be consistent with other plots and to maintain only one copy of config files and sample data

* moved data and config files to test/roc_diagram, instructions updated to reflect this

* fix some directory instructions that didn't get updated

* fixed another directory path

* fixed yet another directory path

* simplify directory for user space

* Need a minimal config file for instructions in the Users Guide

* Still finding out of date directory paths

* Github issue #153 moved sample data to the test/roc_diagram directory

* updates after verifying instructions are correct

* many updates, instructions should be correct

* replace previous version with this version, which has more comments

* moved from the source code to here to be consistent with other plots

* comment out image comparison, fails if you change hosts/OS type

* Delete custom_performance_diagram.yaml

moved to test/performance_diagram to be consistent with other plots and to keep this directory clean

* Delete minimal_performance_diagram.yaml

moved to test/performance_diagram to be consistent with other plots and to keep this directory clean

* Delete plot_20200317_151252.data

moved to test/performance_diagram to be consistent with other plots and to keep this directory clean

* Delete README.rst

redundant- there is now up-to-date documentation on readthedocs.io

* to enable importing this module

* removed WORKING_DIR sentence that was unnecessary

* corrected the relative path for the ROC data

* remove redundant entry

* updates to reflect instructions so all users can follow, regardless of their permissions

* updates to wording to be more concise with respect to saving intermediate files

* plots that were missing from the original documentation

* replace roc with performance diagram (cut-and-paste error)

* Updates to reflect requested changes from PR#168

* Address incorrect formatting of the last bullet point on the page

* fix errors with bullets

* fix errors with bullets

* more additions from documentation requests related to PR #168

* fix formatting for bold text

* removed unneccessary instructions for the stat_input in the default config file

* add default plot image

* fixed typo in instructions

* Add instructions for setting METPLOTPY_BASE

* latest updates

* added cleanup and updated to match documentation

* some temp files weren't getting cleaned up, now cleanup is working

* Delete test_custom_line.yaml

No longer in use

* updates, clean-up

* Delete line.points1

this is output from files, should not be part of test code

* Delete line.points2

created as output from tests, should not be part of source

* initial commit

* removed unused, out of date files

* README is out of date, only maintain the read the docs documentation

* Move data to the test/line directory

* moved from the metplotpy/plots/line directory

* updates to make tests consistent across all plots

* updated for new location of data

* additional test

* fixed broken tests

* remove irrelevant section

* updated paths for file includes

* updates and new plot added

* moved the minimal config file (simple_box.yaml) to test dir, fixed cleaning up of temp files

* additional comments

* additional comments

* additional comments

* additional comments

* moved from plots/box directory

* correction to default file description

* added missing default settings

* updates and added default plot image

* fixed rst syntax

* clean up points file

* fixed inconsistencies

* updates for #153

* fixed copy-and-paste errors

* updates to instructions

* fixed typo

* fix rst syntax

* still had rst syntax error

* still had rst syntax error about bullet list

* added yaml as requirement

* fixed copy and paste error (from bar plot)

* Fixed package import location line, added text to the help message and
commented out the view on website command

* Update custom_bar.yaml

added points_path (currently commented out)

* Update custom_box.yaml

added points_path (uncommented)

* Update custom_ens_ss.yaml

added points_path (uncommented)

* correct the comment to the test fixture to match with the test

* Github Issue #153 add points_path setting to the configuration files

* Github #153 updates to the histogram_2d plot

* Delete grid_diag_temperature.nc

moved to the test/histogram_2d directory

* issue #153 refactored to be consistent with other DTC generated plot type behavior, added stub for indicating where to store dump_points_1 points file (when this plot gets incorporated into METviewer)

* files needed for testing and for user instructions

* cleaned up comments

* updates to minimal config file so it is ready for running tests

* no tests are run, the minimal_histogram_2d.yaml file must have explicit paths defined for stat_input and plot_filename to run correctly

Co-authored-by: Hank Fisher <fisherh@seneca.rap.ucar.edu>

* Github #175 create beta4 release

* Update release-notes.rst

hopefully fix the bullet lists that don't end with a blank line

* update the release date

* updates for beta4 release

* removed the -dev tag

* cleaned up formatting to be consistent with previous releases

* Update release-notes.rst

added the missing enhancement for issue #153 (must have been inadvertently deleted when cleaning up formatting)

Co-authored-by: TatianaBurek <tatiana@ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: Minna Win <minnawin@kiowa.rap.ucar.edu>
Co-authored-by: Hank Fisher <fisherh@ucar.edu>
Co-authored-by: Christina Kalb <kalb@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Co-authored-by: Hank Fisher <fisherh@seneca.rap.ucar.edu>

* Revert "Feature 175 v1.1.0 beta4 (#176)" (#177)

This reverts commit b147990.

* Update README.md

* Update README.md

python modules, input files and variables, learned to indent and format
Need to add installation and running instructions and show example output.

* Update README.md

command examples

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

cnvgwd -> congwd

* rename cnvgwd->congwd, assign name of lat and lon variables

* Carry along long_name for title

make sure "resid" is an option

Use fv3 module for lat and lon variable names.

* Use fv3 module for lat and lon names.

Use visible instead of b argument for ax.grid().

* Renamed variables, more comments

all_tend -> total_change -> da2plot

change vertical units from mb to hPa for metpy.

* minor ticks in vertical profile

fix bug with resid being treated as Boolean, when it could be
a DataArray.

smaller markersize in vertical profile

* Modified the PR template to add review of the source issue metadata ci-skip-all

* add mp to ugrd and vgrd

* Subtract field

logging module

don't call units like a dictionary to avoid warning

Use xarray.set_options(keep_attrs=True) when subtracting to keep attributes.

Use variable+"_i" as initial value.

* don't dequantify twice

* logging module and --subtract option

* Update README.md

add mp to ugrd and vgrd

* Update README.md

* Update version

update for next release

* quantify the var_i variable also

* Update polar_plot.rst

fix location of config file

* logging not print statement

* Work with 24-h history file.

No more model time step.  Just output interval (1hour)

Put [var]_i (variable at initial time) in a new Dataset with an
expanded time dimension. It's time is 1 h earlier than earliest time in
history file's
time-dependent variables. The history file's time-dependent variables
start at first output time, not initialization time.

Budget is balanced, but tendencies are 3x smaller than those in
May's budget_multipanel.py script.

Time window and valid time may be specified with command line arguments.

* 1st commit

* Update README.md

* Update README.md

* Update README.md

* Feature 223 points files (#225)

* Issue #223 points file with NaNs, keep as a test to verify that any NaNs in a file are being found

* Issue #223 address discrepency between Pyton 3.6 and Python 3.8 duck typing in pandas object for isin()

* issue #223 add a nan.points1 file to verify that checking for NaN's is working correctly

* Issue #223 fix duck typing issue in comparisons in Panda Series

* Issue #223 add test for NaN in points1 file

* Issue #223 added test to check for NaN in line plot's points files

* issue #223 nan points file to verify code that checks for NaNs is working

* Issue #223 added test to check for NaNs in the box points1 file

* use Python 3.8 packages

* Issue #223 use requirements.txt to install Python3.8.12 dependencies

* fixed identification in write_output_file method

* Add default operation value "DIFF" to the derived series #226 (#227)

* change Linked issue/Development issue ci-skip-all

* change Linked issue/Development issue ci-skip-all

* change Linked issue/Development issue ci-skip-all

* change Linked issue/Development issue

* fixed indentation  during the grouping/ungrouping

* fixed indentation  in write_output_file

* Feature 208 py38 packages (#222)

* first version

* update to py38 and use requirements.txt instead of explicit pip install commands

* first version of package requirements for Pythob 3.8.12

* remove matplotlib-base

* replace python-kaleido with kaleido

* added py-opencv=4.5.3

* missing second = in opencv version

* replaced py-opencv from conda to opencv-python for pypi

* relax version for opencv

* Update requirements.txt

Added the opencv with a more permissive version, allowing anything above 4.5.3

* Update unit_tests.yaml

add test for Python 3.8.6 in addition to Python 3.8.12

* Update unit_tests.yaml

fixed typo on line 24

Co-authored-by: Minna Win <minnawin@seneca.rap.ucar.edu>

* Change Linked issue/Development issue ci-skip-all

* Feature 230 warnings (#234)

* issue #230 to ignore numpy All-NaN slice RuntiimeWarning for tests involving the PCT and CTC line types

* Issue #230 add RuntimeWarning to simplefilter to suppress third-party warnings

* Issue #230 add DeprecationWarning to simple filter to suppress third-party warning and replace series.append with pandas.concat to address pandas deprecation

* Issue #230 address pandas deprecation by using pd.concat rather than series.append; also removed unused imports

* Issue #230 replace Series.append with pd.concat to address pandas deprecation

* Issue #230 replace Series.append with pd.concat to address pandas FutureWarning

* Issue #230 move order of tests to avoid strange artifact with RuntimeWarning numpy.ndarray size changed

* Issue #230 turn multiple keys to explicit list in groupby to address Pandas FutureWarning

* remove unused env and out of date comments

* issue #230 ignore the RuntimeWarning from pandas and numpy when a NaN value is encountered with nanmean, nanmedian, etc. It is supposed to ignore when a NaN value is encountered, not send a RuntimeWarning

* Delete pytest.ini

Remove this and put warnings in the line_series.py code, where the RuntimeWarning is getting generated from numpy.

* #230 Remove the warning filters, they go in the line_series.py code

* #230 catch the All-NaN RuntimeWarnings in the code that calls the nanfunctions

* issue #230 use context manager to catch the All-NaN slice RuntimeWarning where the nanmean/nanmedian/nanfunction code is getting called

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* reinstated the import for pytest, which got accidentally removed when removing outdated comments

* Update hovmoeller.rst

replace metplotpy with metcalcpy as a required package

* optional conversion of time to datetimeindex

* don't prefix scripts with fv3. It makes autocompletion harder

* Added cross_section_vert.py.

Shares variable and function definitions with planview_fv3.py.
Put shared resources in fv3.py.

Reverse Spectral colormap so blue is low and red is high.

* test mask with shapefile

* Add CONUS inset of region of interest

averaging area to vert_profile_fv3.py.
path of cross section to cross_section_vert.py.

* Update README.md

* Update README.md

* fix description and help comments in argparse

* turn off CFTimeIndex warning

* less verbosity

* fixed name of script

* option to log-linear or linear interpolate in vertical

* Update README.md

* print requested levels

* Feature 213 hovmoeller configurable (#236)

* #213 remove timezone information passed into numpy datetime64, this is deprecated and will raise an error in the future.

* #213 updates to make things more configurable

* #213 updates to accomodate custom config file and configurability

* Issue #213

* Issue #213 expected Hovmoeller

* Delete hovmoeller.yaml

no longer relevant.  Configuration file corresponds to previous plot code.

* Issue #213 updates to tests and config files

* Issue #213, use METcalcpy's parser to read in the yaml file that has ENV variables set. This supports the s2s Hovmoeller METplus use case

* Issue #213 remove argparse, logger imports and remove the original method of getting the configuration dictionary

* Issue #213 input_data_file setting is more consistent with other default config files

* Issue #213 use only the input_data_file to handle path and filename

* Issue #213 updates to the input_data_file setting

* Issue #213 updates to test

* Issue #213. Create the output directory for the plot if it doesn't already exist.  This is especially important for plotly

* Issue #213 example Hovmoeller plots for default/minimal and custom config

* Issue #213 replace hard-coded path to data with generic path

* Issue #213 add more information in the comment block

* Issue #213 updates for the configurable hovmoeller plot

* Issue #213 updates for updates to refactored, configurable hovmoeller script

* Issue #213 update to Python package versions

* Issue #213 update versions that correspond to Python 3.8.6

* Issue #213 clean up some formatting

* fix instructions- originally incorrectly instructed user to modify path to the METPLOTPY_BASE/xyz but should actually be changes to the WORKING_DIR/

* Update instructions for PYTHONPATH

* correct the instructions for modifying the config files

* Issue #213 fix incorrect instructions

* Issue #213 add instructions for setting PYTHONPATH

* Feature 217 line (#231)

* issue #217 additional files to verify that start_from_zero plot is matching what is expected

* Issue #217 Added the start_from_zero configuration setting

* #217 added support for changing the x-axis starting point

* Issue #217 added support for reading in the start_from_zero config setting

* Issue #217 fixed retrieving of start_from_zero setting

* Issue #217 fixed start_from_zero, should be a setting, not a list item from the previous setting

* #217 added image test for start_from_zero

* #217 skip image comparison tests, they only work on MacOS

* Issue #237 updates to dates, versions for beta1 release (#239)

* Issue #237 updates to dates, versions for beta1 release

* Issue #237 updates for beta1 release

* Update version

set up for beta2 development

* python package and installation detail

* added test images

* added test images

* Update README.md

* example from May W. functionality assimilated into other scripts

* Fix logic that finds metplotpy/plots/config directory to find default config file. os.getcwd() does not get the directory where this script is found. os.path.dirname(__file__) gets the containing directory and config is added (#238)

* Feature 232 revision series (#241)

* Add Revision series capability to the line plot #232

* move the legend vertically #232

* check if series_line_width parameter exists #232

* Add Revision series capability to the line plot #232

* Add Revision series capability to the line plot #232

* Add Revision Box capability to the line plot #232

* Check if xaxis_reverse exists. eed for the plot that don't support this feature #232

* Check if series_val_2 exists. need for the plot that don't support y2 axis #232

* use _get_bool method to read boolean parameters revision_ac and revision_run #232

* new version #232

* remove lag_max static value from the calculation of autocovariance. Use default instead #232

* fix pypos #232

* new version #232

* do not produce html #232

* Add Revision Box capability #232

* Add Revision Box capability #232

* changed logic to build path to plot output so that trailing forward slash is not required in the value set for plotpath in the YAML config file

* started with hovmoeller.rst and modified

* Update fv3_physics.rst

adapted from README.md

* Update fv3_physics.rst

rearranged

figured out how to insert code with "copy" option that pops up for user

* print->logging in fv3. copy varnames and plot config to yaml

* better comments in yaml, removed same params from fv3.py

* seems like better place for yaml defaults

* note about yaml file holding variable names

* Update fv3_physics.rst

link to yaml config

elaborate on description, remove some extraneous wording from template

* Update fv3_physics.rst

separate tables for tendency nicknames and expected netcdf variable names

* Update fv3_physics.rst

typo in literal include

* Feature 243 v2.0.0 beta2 (#244)

* beta2

* beta2 rotate contributors for 2.0

* beta2

* fv3.py -> physics_tend.py

Moved some variables (variable string names in FV3 history file) from
physics_tend.py to yaml.

Commented out progress bar tqdm.

* Update fv3_physics.rst

remove highlighted image file names

* renamed physics_tend.py

* better comments

* Update fv3_physics.rst

added --nofineprint option

* where should this file live?

* added --nofineprint option

* Update README.md

moved most of this to User Guide

* Update fv3_physics.rst

Introduce plot types with underlined headings

* Update fv3_physics.rst

remove link to use case. 
change to generic url for sample data until I add real one

* Update version

update for beta3 development

* moved custom config from plots to test

* Update release-notes.rst

Add sonarqube task

* included the fv3_physics to toc

* fixed directory path to the test directory

* Add to table of contents

simply links to images in User Guide

* Add to table of contents

fix link to images in Users Guide

* removed duplicate entry in toctree

* Modified METdatadb references to be METdataio

* Moved from internal_tests/scanning directory to internal/scripts (#248)

Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>

* Adding modulefiles for installation on various machines (#252)

* config file arg, make non-existent odir

* mandatory config arg, pared-down history file

* initial commit for testing

* test output when -h is only argument besides input files

* add test to check if output plot is created, currently fails because of hard-coding in physics_tend.py

* pass fv3 dict to add_time0 instead of reading from config file

* use the correct yaml config file in the command

* add test to check for the plot that should be created when running the example in the user's guide

* skipping tests that check the output file config, these aren't working

* fix function that uses the -o option, creating a file in the cwd

* output filename

Don't overwrite user-supplied output filename.
This happened when shp was True and when appending time window to
output filename.

* just 3 times in pared-down history file

* remove time window from output image filenames

* new test script and images

* define CONFIG with METPLOTPY_BASE

* updates after latest changes

* rename test shapefiles.

* useful utilites for testing

* Updated name of yaml config file for the runner to something more generic.  The other tests will also use this same yaml config file.

* Added description of what METPLOTPY_BASE following first reference.  Explicitly put the full path to the MID_CONUS shapefiles in the instructions for running the vertical profile

* runner for the vertical profile plot

* renamed to runner_fv3_phys.yaml

* common yaml to be used for all test files

* tests for the vertical profile plot

* initial checkin of vertical cross section runner

* remove novel output dir in clean up

* added tests for vertical cross section plot

* Added functions for each scenario to be tested

* Fixed order of cleaning up in test_novel_output_dir

* Modifications for using truncated data.

* Updates to commands due to using truncated data.

* Added function for creating the vertical profile difference plot.

* Tests that the vertical profile difference plot is created

* Removed redundant code

* Added information on downloading the sample data.

Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Co-authored-by: Hank Fisher <fisherh@ucar.edu>
Co-authored-by: bikegeek <3753118+bikegeek@users.noreply.github.com>
Co-authored-by: TatianaBurek <tatiana@ucar.edu>
Co-authored-by: Minna Win <minnawin@kiowa.rap.ucar.edu>
Co-authored-by: Christina Kalb <kalb@ucar.edu>
Co-authored-by: Hank Fisher <fisherh@seneca.rap.ucar.edu>
Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com>
Co-authored-by: Minna Win <minnawin@seneca.rap.ucar.edu>
Co-authored-by: bikegeek <minnawin@ucar.edu>
Co-authored-by: hsoh-u <hsoh@ucar.edu>
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
bikegeek added a commit that referenced this issue Sep 7, 2022
* Migrate issue and PR template changes from PR MET/#1803 into METplotpy main_v1.0 branch.

* Update README.md

Added GitHub Discussions info

* changed non-unicode apostrophe and fixed typo in URL

* Feature 121 main v1.0 discussions (#134)

* For #121, removed references to met_help@ucar.edu where an email was listed, and replace with a link to GitHub Discussions where appropriate

* Removed docs/metplotpy_docs.tar

* Fix stale URL in GitHub issue and pull request templates.

* Updated release version and date

* Added documentation link

* Update issue templates

Added new default labels

* Initial directory checkin

* copied plan view and vertical profile scripts to local git branch

* Adding changes necessary for a successful RTD build

* read_fv3_history.py does more than just read

* Removed "read" from name

* update arg s in plt.annotate to text

* Use xarray.plot.pcolormesh

No more computing lat/lon increments.

Make shp argument a directory name not a file name.

Let xarray do colorbar.

LambertConformal not working yet.

* dictionary of tendencies for each state variable

* Put tendency dict in fv3.py

Rename tquv state_variable.

Calculate area of unmasked region.

Assign dstate_variable and resid to DataSet so it all can be plotted in one line.

TODO: put markers on dstate_variable and resid lines in axes and legend.

* define state_variables array

* put st4.pts_in_shp in fv3 module

* use fv3.pts_in_shp, not st4.pts_in_shp

* Reassign correct long_name attrs.

assign latt and lont to fv3ds before splitting out all_tend.

Don't bother adding resid, state_variable, and dstate_variable to "tendency" axis of all_tend,
as in fv3_vert_profile.py.

* Reassign long_name with "tendency" changed to "change"

after multiplying tendency by time

* Remove TODO comment about preserving long_names

* Use __name__ == "__main__" idiom

Trim du3dt from variable names.

Add state_variable to name of tendency dimension (for nice legend title).

Add special symbol to residual and dstate_variable lines, both on line and in legend.

Make residual an option. Sometimes it is so big it swamps all other terms.

Cosmetic changes to fine print.

* use .geoms in shapely iteration

* Reorder mandatory args.

Now start with state variable (tmp, ugrd, etc.),
followed by tendency type (mp, etc)

tendency type can be empty string "" or d{state_variable} or "resid"

encapsulate parse_args and main()

Remove extent

If shp is used for mask, drop masked coordinates so extent is automatically zoomed in.

* rename state variable argument

* history to planview

* fixed lambert conformal projection\n\nadded transform=ccrs.PlateCarree() to DataArray.plot.pcolormesh

* comment about dimension of facetview

* Feature 175 v1.1.0 beta4 (#176)

* original version #9

* check if some optional parameter exist before assign them to the variables #9

* fixed the images names for the comparison

* fixed the images names for the comparison

* Migrate issue and PR template changes from PR MET/#1803 into METplotpy develop branch.

* add show_in_browser property to the wind_rose #9

* add show_in_browser property to the wind_rose #9

* remove ./ before the file name #9

* remove stat_input property. Will use provided point_stat_mpr.txt by default #9

* rename the file #9

* by default point to data file in the test dir #9

* add nicenumber and pretty methods that are used in mpr_plot #9

* original version #9

* original version #9

* original version #9

* Update README.md

Added GitHub Discussions info.

* changed non-unicode apostrophe and fixed typo in URL

* add the error message if one of the derived components is a group #79

* move plotting script (and add __init__.py) from METcalcpy repository

* Modifications to automation settings to fail on documentation warnings

* Modifications to automation settings to fail on documentation warnings

* Delete main.yml

* added text

* fixed incorrect issue number for github issue #84

* update the preferences #119

* fixes for the optional properties #119

* updates for METviewer #119

* add indy var to filters #119

* improve the file name for HTML output #119

* initial version

* added mpr_file_list property and the data file to it #115 #9

* change the datatype from string to str #115 #9

* removed mpr_file_list property from the default. It always should be in the user-supplied yaml  #115 #9

* Added build docs file

* initial version #119

* initial version #119

* save points for the each series and indy_val #119

* add box plot documentation file to index.rst  #119

* fixed path to custom_box.yaml  #119

* add references  #119

* reverse x2axis if xaxis_reverse was selected  #119

* check boolean values against True  #119

* committed show_in_browser  #119

* Change the names of the CI data columns from bcl/bcu to btcl/btcu in Reliability plot #124

* Change the names of the CI data columns from bcl/bcu to btcl/btcu in Reliability plot #124

* Use METcalcpy correlation instead of from pingouin library #127

* Initial version of documentation for the mjo plotting provided by NOAA/Maria Gehne.

* Fixed typos that generate warnings

* Fixed typo and added more text

* Added mjo_rmm_omi to toc tree

* Removed incorrect formatting

* do not sort by 'fcst_lead' if it is not in the data columns list #129

* Removed pingouin and bootstrapped requirments as these dependencies have been removed

* Updates for v1.1.0 beta1

* updated for v1.1.0 beta1

* Update version

updated for beta2

* Update version

added the -dev to indicate that the next version is the development version for beta2

* do not sort by 'fcst_lead' if it is not in the data columns list #129

* Added Frequency Plots

* add box.png to be checked

* updated image

* initial version

* initial version #126

* initial version #126

* remove parameters for box

* initial version #126

* initial version #126

* added bar #126

* initial version #126

* Feature 121 develop discussions (#133)

* For #121, removed references to met_help@ucar.edu where an email was listed, and replace with a link to GitHub Discussions where appropriate

* Removed docs/metplotpy_docs.tar

* Add the Python implementation of the ens_ss plot #308

* Add the Python implementation of the ens_ss plot #308

* Add the Python implementation of the ens_ss plot #308

* Add the Python implementation of the ens_ss plot #308

* plot_stat parameter is optional

* close the points file

* fixed the file name

* close the points file

* fixed the file name

* fixed the file name

* close the points file

* close the points file

* Add the Python implementation of the ens_ss plot #308

* fixed path to custom_ens_ss.yaml #308

* Fix stale URL in GitHub issue and pull request templates.

* Delete METLoadEnsemble_NEW.py

No new updates from Mike Erickson (8/11/2021).  Deleting this as requested.

* Delete mtd_retroruns_save_NEWSeTEST.py

Deleted as requested by Mike Erickson (8/11/2021), no update in the 8/11/2021 code.

* Description of latest additions from Mike Erickson

* Update README

* Update README

* Latest from Mike Erickson 8/11/2021

* Latest updates from Mike Erickson NOAA/WPC 8/11/2021

* added methods to plot horizontal and vertical lines #142

* moved series_data attribute to the base class and added a new method to check beta_value #142

* include a method to check beta_value #142

* moved series_data attribute to the base class #142

* moved series_data attribute to the base class #142

* Adding documentation link

* Added additional default labels

* Updates for beta2

* Update for beta2 release

* Fixed formatting errors

* Update release-notes.rst

removed additional line feeds

* Update version

update for beta3 development

* include both  y1/y1 series in min/max range for the axis sync

* remove unused parameter 'list_static_val' #150

* Change ',' as a separator for the series group to ':' #152

* Adding changes necessary for a successful RTD build

* Change the names of the CI data columns from bcl/bcu to btcl/btcu  fot boot #156

* commented out show_in_browser

* Remove the -dev portion of the version number

* Updates for the beta3 release.

* Fix formatting

* Close emphasis command

* update version for next beta development

* added indy_plot_val and create_list_by_plot_val_ordering method to accommodate reordering based on  plot_val values #161

* usr ordered indy values #161

* Update installation.rst

update the version of cartopy from 0.17 to 0.18 (the 0.18 version does NOT cause an overlap of the 180/-180 longitude line when the central longitude is set to 180)

* plots with groups with date values don't get created (#164)

Use regex for parsing #163

* Issue/157 revision mtd (#166)

* mtd_revision #157

* prototype functions for  Revision series for MODE-TD #157

* added showlegend=True to the plot so the legend is always printed #157

* change the series name by adding revision stats if needed #157

* fix handling missing box parameters #157

* Issue/141 histogram (#169)

* make plot_stat optional #141

* Create rhist plot to be used by METviewer #141

* Create rhist plot to be used by METviewer #141

* Create rhist plot to be used by METviewer #141

* initial version #141

* added PHistogramConfig #141

* improve x-axis grid appearance #141

* initial version #141

* initial version #141

* initial version #141

* initial version #141

* initial version #141

* initial version #141

* initial version #141

* Feature 153 intermed files (#168)

* Github Issue #153 intermediary files: provide support for turning on/off the writing of intermediary file used by METviewer by setting dump_points_1 to True or False.

* Github #153 update the comment to reflect what is being overridden

* Github issue #153 fixed incorrect behavior

* Github issue #153 add support for turning on/off the writing of intermediate file used by METviewer by collecting the value of the dump_file_1 setting.

* Github issue #153 overwrite the default config and turn off writing of intermediate file.

* Github Issue #153 revert to original, keep this simple to use all the settings in the default config file.

* Github Issue #153 set the default behavior to write the intermediate file used by METviewer

* Github issue #153 clean up order of options to be consistent with default config and provide support for turning on/off the creating of intermediate file used by METviewer.

* Github Issue #153 support for turning off the writing of the intermediate file used by METviewer

* Github Issue #153 provide support for turning on/off writing intermediate output file used by METviewer

* Github issue #153 by default, turn on the creation of the intermediate file used by METviewer

* needed for running tests

* Needed for imports

* Needed for imports

* Github #153 update config setting

* Github issue #153 update config settings

* Clean up import and cleaning up of output files in between tests

* Github issue #153 by default, set dump_files option to "False"

* Github issue #153 by default, turn off creating intermediate points1 file used by METviewer

* Github issue #153 by default, turn off creating the intermediate .points1 file used by METviewer

* Github Issue #153 override the dump_points setting in the default config and generate the .points1 file used by METviewer

* Github issue #153 turn on the creation of the .points1 file used by METviewer

* Github issue #153 do not request the generation of .points1 file used by METviewer

* Update custom_performance_diagram.yaml

Turn off creation of the .points1 file used by METviewer

* Github Issue #153 Add this so the appropriate modules are imported

* To be consistent with performance diagram, explicitly list what should be imported with roc_diagram

* Github Issue #153 updated assert

* Delete plot_20200317_151252.points1

not needed for tests, this no longer gets generated in the test config file

* Delete test_performance_diagram.py

doesn't work, replacing with new test

* Working version

* test_performance_diagram

working version

* Hint for setting the PYTHONPATH to run the test from the command line

* Update custom_performance_diagram.yaml

set the dump_points_1 to 'False' to prevent creating the .points1 file

* Github Issue #153 Allow user to specify where to save the .points1 file.

* Github Issue #153 support to allow user to specify WHERE to save the points1 file

* Github Issue #153 Support for specifying location for storing the points1 file

* updates to test to reflect support for specifying where intermediate file gets saved

* Github Issue #153 added additional informative comment to the points_path config option

* Github issue #153 support for specifying where the save the points1 file via the points_path configuration setting

* Reorganized lines of code

* updates to test for Issue #153 intermediate files

* Hint for running via command line

* new config files used for testing

* Additional tests for Github issue #153

* uncomment all, now all tests will run

* updated tests for Github issue #153

* Github Issue #153 added support to indicate where to save points1 file-default location if points_path is absent, or user-spceified directory if set

* support for Github issue #153- specify where to save points1 file via points_path config setting (absence indicates saving to default location)

* Github Issue #153 support for indicating where points1 files are to be saved via points_path config option

* Github Issue #153 changed regex to support file input, reorganized code

* Github Issue #153 additional test code and configs, code cleanup

* use os.rmdir to remove temp directory created during testing

* use os.rmdir to remove subdir created during testing

* Github Issue #153 additional config and test

* Github Issue #153 support for the optional setting points_path, which indicates where to store the points1 intermediate file

* fixed comment for class name info

* add import to import the GROUP_SEPARATOR (which is defined in the __init__.py file for the METplotpy plots package)

* Github Issue #153 support for optional points_path to indicate where to save the points1 files outside of its default location

* use to compare all plots against

* Github issue #153 updates to tests and config files

* Github Issue #153 support for optional points_path config setting

* Github Issue #153 updates to config and tests

* Github Issue #153 support for the optional points_path configuration setting

* Remove temporary subdirs

* Github Issue #153 updates to testing and configs

* Github Issue #153 support for optional points_path

* Github Issue #153 update documentation for ROC diagram so users with limited file/directory permissions can run in their environment.

* remove the 'hello' hidden in the page

* fixed incorrect path to config file in literalincludes

* Cleaned up some formatting and wording

* fixed errors in directory name

* fix more instructions

* fix more errors

* fix more errors

* fix line 75?

* fix line 124?

* fixed incorrect config file names in instructions

* Github Issue #153 move config files from plots/roc_diagram to test/roc_diagram to be consistent with other plots and to maintain only one copy of config files and sample data

* moved data and config files to test/roc_diagram, instructions updated to reflect this

* fix some directory instructions that didn't get updated

* fixed another directory path

* fixed yet another directory path

* simplify directory for user space

* Need a minimal config file for instructions in the Users Guide

* Still finding out of date directory paths

* Github issue #153 moved sample data to the test/roc_diagram directory

* updates after verifying instructions are correct

* many updates, instructions should be correct

* replace previous version with this version, which has more comments

* moved from the source code to here to be consistent with other plots

* comment out image comparison, fails if you change hosts/OS type

* Delete custom_performance_diagram.yaml

moved to test/performance_diagram to be consistent with other plots and to keep this directory clean

* Delete minimal_performance_diagram.yaml

moved to test/performance_diagram to be consistent with other plots and to keep this directory clean

* Delete plot_20200317_151252.data

moved to test/performance_diagram to be consistent with other plots and to keep this directory clean

* Delete README.rst

redundant- there is now up-to-date documentation on readthedocs.io

* to enable importing this module

* removed WORKING_DIR sentence that was unnecessary

* corrected the relative path for the ROC data

* remove redundant entry

* updates to reflect instructions so all users can follow, regardless of their permissions

* updates to wording to be more concise with respect to saving intermediate files

* plots that were missing from the original documentation

* replace roc with performance diagram (cut-and-paste error)

* Updates to reflect requested changes from PR#168

* Address incorrect formatting of the last bullet point on the page

* fix errors with bullets

* fix errors with bullets

* more additions from documentation requests related to PR #168

* fix formatting for bold text

* removed unneccessary instructions for the stat_input in the default config file

* add default plot image

* fixed typo in instructions

* Add instructions for setting METPLOTPY_BASE

* latest updates

* added cleanup and updated to match documentation

* some temp files weren't getting cleaned up, now cleanup is working

* Delete test_custom_line.yaml

No longer in use

* updates, clean-up

* Delete line.points1

this is output from files, should not be part of test code

* Delete line.points2

created as output from tests, should not be part of source

* initial commit

* removed unused, out of date files

* README is out of date, only maintain the read the docs documentation

* Move data to the test/line directory

* moved from the metplotpy/plots/line directory

* updates to make tests consistent across all plots

* updated for new location of data

* additional test

* fixed broken tests

* remove irrelevant section

* updated paths for file includes

* updates and new plot added

* moved the minimal config file (simple_box.yaml) to test dir, fixed cleaning up of temp files

* additional comments

* additional comments

* additional comments

* additional comments

* moved from plots/box directory

* correction to default file description

* added missing default settings

* updates and added default plot image

* fixed rst syntax

* clean up points file

* fixed inconsistencies

* updates for #153

* fixed copy-and-paste errors

* updates to instructions

* fixed typo

* fix rst syntax

* still had rst syntax error

* still had rst syntax error about bullet list

* added yaml as requirement

* fixed copy and paste error (from bar plot)

* Fixed package import location line, added text to the help message and
commented out the view on website command

* Update custom_bar.yaml

added points_path (currently commented out)

* Update custom_box.yaml

added points_path (uncommented)

* Update custom_ens_ss.yaml

added points_path (uncommented)

* correct the comment to the test fixture to match with the test

* Github Issue #153 add points_path setting to the configuration files

* Github #153 updates to the histogram_2d plot

* Delete grid_diag_temperature.nc

moved to the test/histogram_2d directory

* issue #153 refactored to be consistent with other DTC generated plot type behavior, added stub for indicating where to store dump_points_1 points file (when this plot gets incorporated into METviewer)

* files needed for testing and for user instructions

* cleaned up comments

* updates to minimal config file so it is ready for running tests

* no tests are run, the minimal_histogram_2d.yaml file must have explicit paths defined for stat_input and plot_filename to run correctly

Co-authored-by: Hank Fisher <fisherh@seneca.rap.ucar.edu>

* Github #175 create beta4 release

* Update release-notes.rst

hopefully fix the bullet lists that don't end with a blank line

* update the release date

* updates for beta4 release

* removed the -dev tag

* cleaned up formatting to be consistent with previous releases

* Update release-notes.rst

added the missing enhancement for issue #153 (must have been inadvertently deleted when cleaning up formatting)

Co-authored-by: TatianaBurek <tatiana@ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: Minna Win <minnawin@kiowa.rap.ucar.edu>
Co-authored-by: Hank Fisher <fisherh@ucar.edu>
Co-authored-by: Christina Kalb <kalb@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Co-authored-by: Hank Fisher <fisherh@seneca.rap.ucar.edu>

* Revert "Feature 175 v1.1.0 beta4 (#176)" (#177)

This reverts commit b147990.

* Update README.md

* Update README.md

python modules, input files and variables, learned to indent and format
Need to add installation and running instructions and show example output.

* Update README.md

command examples

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

cnvgwd -> congwd

* rename cnvgwd->congwd, assign name of lat and lon variables

* Carry along long_name for title

make sure "resid" is an option

Use fv3 module for lat and lon variable names.

* Use fv3 module for lat and lon names.

Use visible instead of b argument for ax.grid().

* Renamed variables, more comments

all_tend -> total_change -> da2plot

change vertical units from mb to hPa for metpy.

* minor ticks in vertical profile

fix bug with resid being treated as Boolean, when it could be
a DataArray.

smaller markersize in vertical profile

* Modified the PR template to add review of the source issue metadata ci-skip-all

* add mp to ugrd and vgrd

* Subtract field

logging module

don't call units like a dictionary to avoid warning

Use xarray.set_options(keep_attrs=True) when subtracting to keep attributes.

Use variable+"_i" as initial value.

* don't dequantify twice

* logging module and --subtract option

* Update README.md

add mp to ugrd and vgrd

* Update README.md

* Update conf.py

forgot to update version

* quantify the var_i variable also

* Update polar_plot.rst

fix location of the config file

* logging not print statement

* Work with 24-h history file.

No more model time step.  Just output interval (1hour)

Put [var]_i (variable at initial time) in a new Dataset with an
expanded time dimension. It's time is 1 h earlier than earliest time in
history file's
time-dependent variables. The history file's time-dependent variables
start at first output time, not initialization time.

Budget is balanced, but tendencies are 3x smaller than those in
May's budget_multipanel.py script.

Time window and valid time may be specified with command line arguments.

* 1st commit

* Update README.md

* Update README.md

* Update README.md

* Update hovmoeller.rst

for required packages, replace metplotpy with metcalcpy.

* optional conversion of time to datetimeindex

* don't prefix scripts with fv3. It makes autocompletion harder

* Added cross_section_vert.py.

Shares variable and function definitions with planview_fv3.py.
Put shared resources in fv3.py.

Reverse Spectral colormap so blue is low and red is high.

* test mask with shapefile

* Add CONUS inset of region of interest

averaging area to vert_profile_fv3.py.
path of cross section to cross_section_vert.py.

* Update README.md

* Update README.md

* fix description and help comments in argparse

* turn off CFTimeIndex warning

* less verbosity

* fixed name of script

* option to log-linear or linear interpolate in vertical

* Update README.md

* print requested levels

* python package and installation detail

* added test images

* added test images

* Update README.md

* example from May W. functionality assimilated into other scripts

* started with hovmoeller.rst and modified

* Update fv3_physics.rst

adapted from README.md

* Update fv3_physics.rst

rearranged

figured out how to insert code with "copy" option that pops up for user

* METplus-Internal_38 SonarQube scanning (#242)

* Update version

update for next release

* Update polar_plot.rst

fix location of config file

* Feature 223 points files (#225)

* Issue #223 points file with NaNs, keep as a test to verify that any NaNs in a file are being found

* Issue #223 address discrepency between Pyton 3.6 and Python 3.8 duck typing in pandas object for isin()

* issue #223 add a nan.points1 file to verify that checking for NaN's is working correctly

* Issue #223 fix duck typing issue in comparisons in Panda Series

* Issue #223 add test for NaN in points1 file

* Issue #223 added test to check for NaN in line plot's points files

* issue #223 nan points file to verify code that checks for NaNs is working

* Issue #223 added test to check for NaNs in the box points1 file

* use Python 3.8 packages

* Issue #223 use requirements.txt to install Python3.8.12 dependencies

* fixed identification in write_output_file method

* Add default operation value "DIFF" to the derived series #226 (#227)

* change Linked issue/Development issue ci-skip-all

* change Linked issue/Development issue ci-skip-all

* change Linked issue/Development issue ci-skip-all

* change Linked issue/Development issue

* fixed indentation  during the grouping/ungrouping

* fixed indentation  in write_output_file

* Feature 208 py38 packages (#222)

* first version

* update to py38 and use requirements.txt instead of explicit pip install commands

* first version of package requirements for Pythob 3.8.12

* remove matplotlib-base

* replace python-kaleido with kaleido

* added py-opencv=4.5.3

* missing second = in opencv version

* replaced py-opencv from conda to opencv-python for pypi

* relax version for opencv

* Update requirements.txt

Added the opencv with a more permissive version, allowing anything above 4.5.3

* Update unit_tests.yaml

add test for Python 3.8.6 in addition to Python 3.8.12

* Update unit_tests.yaml

fixed typo on line 24

Co-authored-by: Minna Win <minnawin@seneca.rap.ucar.edu>

* Change Linked issue/Development issue ci-skip-all

* Feature 230 warnings (#234)

* issue #230 to ignore numpy All-NaN slice RuntiimeWarning for tests involving the PCT and CTC line types

* Issue #230 add RuntimeWarning to simplefilter to suppress third-party warnings

* Issue #230 add DeprecationWarning to simple filter to suppress third-party warning and replace series.append with pandas.concat to address pandas deprecation

* Issue #230 address pandas deprecation by using pd.concat rather than series.append; also removed unused imports

* Issue #230 replace Series.append with pd.concat to address pandas deprecation

* Issue #230 replace Series.append with pd.concat to address pandas FutureWarning

* Issue #230 move order of tests to avoid strange artifact with RuntimeWarning numpy.ndarray size changed

* Issue #230 turn multiple keys to explicit list in groupby to address Pandas FutureWarning

* remove unused env and out of date comments

* issue #230 ignore the RuntimeWarning from pandas and numpy when a NaN value is encountered with nanmean, nanmedian, etc. It is supposed to ignore when a NaN value is encountered, not send a RuntimeWarning

* Delete pytest.ini

Remove this and put warnings in the line_series.py code, where the RuntimeWarning is getting generated from numpy.

* #230 Remove the warning filters, they go in the line_series.py code

* #230 catch the All-NaN RuntimeWarnings in the code that calls the nanfunctions

* issue #230 use context manager to catch the All-NaN slice RuntimeWarning where the nanmean/nanmedian/nanfunction code is getting called

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* remove outdated comments

* reinstated the import for pytest, which got accidentally removed when removing outdated comments

* Update hovmoeller.rst

replace metplotpy with metcalcpy as a required package

* Feature 213 hovmoeller configurable (#236)

* #213 remove timezone information passed into numpy datetime64, this is deprecated and will raise an error in the future.

* #213 updates to make things more configurable

* #213 updates to accomodate custom config file and configurability

* Issue #213

* Issue #213 expected Hovmoeller

* Delete hovmoeller.yaml

no longer relevant.  Configuration file corresponds to previous plot code.

* Issue #213 updates to tests and config files

* Issue #213, use METcalcpy's parser to read in the yaml file that has ENV variables set. This supports the s2s Hovmoeller METplus use case

* Issue #213 remove argparse, logger imports and remove the original method of getting the configuration dictionary

* Issue #213 input_data_file setting is more consistent with other default config files

* Issue #213 use only the input_data_file to handle path and filename

* Issue #213 updates to the input_data_file setting

* Issue #213 updates to test

* Issue #213. Create the output directory for the plot if it doesn't already exist.  This is especially important for plotly

* Issue #213 example Hovmoeller plots for default/minimal and custom config

* Issue #213 replace hard-coded path to data with generic path

* Issue #213 add more information in the comment block

* Issue #213 updates for the configurable hovmoeller plot

* Issue #213 updates for updates to refactored, configurable hovmoeller script

* Issue #213 update to Python package versions

* Issue #213 update versions that correspond to Python 3.8.6

* Issue #213 clean up some formatting

* fix instructions- originally incorrectly instructed user to modify path to the METPLOTPY_BASE/xyz but should actually be changes to the WORKING_DIR/

* Update instructions for PYTHONPATH

* correct the instructions for modifying the config files

* Issue #213 fix incorrect instructions

* Issue #213 add instructions for setting PYTHONPATH

* Feature 217 line (#231)

* issue #217 additional files to verify that start_from_zero plot is matching what is expected

* Issue #217 Added the start_from_zero configuration setting

* #217 added support for changing the x-axis starting point

* Issue #217 added support for reading in the start_from_zero config setting

* Issue #217 fixed retrieving of start_from_zero setting

* Issue #217 fixed start_from_zero, should be a setting, not a list item from the previous setting

* #217 added image test for start_from_zero

* #217 skip image comparison tests, they only work on MacOS

* Issue #237 updates to dates, versions for beta1 release (#239)

* Issue #237 updates to dates, versions for beta1 release

* Issue #237 updates for beta1 release

* Update version

set up for beta2 development

* Fix logic that finds metplotpy/plots/config directory to find default config file. os.getcwd() does not get the directory where this script is found. os.path.dirname(__file__) gets the containing directory and config is added (#238)

* Feature 232 revision series (#241)

* Add Revision series capability to the line plot #232

* move the legend vertically #232

* check if series_line_width parameter exists #232

* Add Revision series capability to the line plot #232

* Add Revision series capability to the line plot #232

* Add Revision Box capability to the line plot #232

* Check if xaxis_reverse exists. eed for the plot that don't support this feature #232

* Check if series_val_2 exists. need for the plot that don't support y2 axis #232

* use _get_bool method to read boolean parameters revision_ac and revision_run #232

* new version #232

* remove lag_max static value from the calculation of autocovariance. Use default instead #232

* fix pypos #232

* new version #232

* do not produce html #232

* Add Revision Box capability #232

* Add Revision Box capability #232

* changed logic to build path to plot output so that trailing forward slash is not required in the value set for plotpath in the YAML config file

* METplus-Internal_37 initial release

Co-authored-by: bikegeek <3753118+bikegeek@users.noreply.github.com>
Co-authored-by: TatianaBurek <tatiana@ucar.edu>
Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com>
Co-authored-by: Minna Win <minnawin@seneca.rap.ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>

* print->logging in fv3. copy varnames and plot config to yaml

* better comments in yaml, removed same params from fv3.py

* seems like better place for yaml defaults

* note about yaml file holding variable names

* Update fv3_physics.rst

link to yaml config

elaborate on description, remove some extraneous wording from template

* Update fv3_physics.rst

separate tables for tendency nicknames and expected netcdf variable names

* Update fv3_physics.rst

typo in literal include

* fv3.py -> physics_tend.py

Moved some variables (variable string names in FV3 history file) from
physics_tend.py to yaml.

Commented out progress bar tqdm.

* Update fv3_physics.rst

remove highlighted image file names

* renamed physics_tend.py

* better comments

* Update fv3_physics.rst

added --nofineprint option

* where should this file live?

* added --nofineprint option

* Update README.md

moved most of this to User Guide

* Update fv3_physics.rst

Introduce plot types with underlined headings

* Update fv3_physics.rst

remove link to use case. 
change to generic url for sample data until I add real one

* moved custom config from plots to test

* included the fv3_physics to toc

* fixed directory path to the test directory

* Add to table of contents

simply links to images in User Guide

* Add to table of contents

fix link to images in Users Guide

* removed duplicate entry in toctree

* Updated METdatadb references to METdataio (#249)

* Revert "METplus-Internal_38 SonarQube scanning (#242)"

This reverts commit d92c707.

* Delete internal_tests directory (#247)

* Update pull_request_template.md (#253)

* config file arg, make non-existent odir

* mandatory config arg, pared-down history file

* initial commit for testing

* test output when -h is only argument besides input files

* add test to check if output plot is created, currently fails because of hard-coding in physics_tend.py

* pass fv3 dict to add_time0 instead of reading from config file

* use the correct yaml config file in the command

* add test to check for the plot that should be created when running the example in the user's guide

* skipping tests that check the output file config, these aren't working

* fix function that uses the -o option, creating a file in the cwd

* output filename

Don't overwrite user-supplied output filename.
This happened when shp was True and when appending time window to
output filename.

* just 3 times in pared-down history file

* remove time window from output image filenames

* new test script and images

* define CONFIG with METPLOTPY_BASE

* updates after latest changes

* rename test shapefiles.

* useful utilites for testing

* Updated name of yaml config file for the runner to something more generic.  The other tests will also use this same yaml config file.

* Added description of what METPLOTPY_BASE following first reference.  Explicitly put the full path to the MID_CONUS shapefiles in the instructions for running the vertical profile

* runner for the vertical profile plot

* renamed to runner_fv3_phys.yaml

* common yaml to be used for all test files

* tests for the vertical profile plot

* initial checkin of vertical cross section runner

* remove novel output dir in clean up

* added tests for vertical cross section plot

* Added functions for each scenario to be tested

* Fixed order of cleaning up in test_novel_output_dir

* Modifications for using truncated data.

* Updates to commands due to using truncated data.

* Added function for creating the vertical profile difference plot.

* Tests that the vertical profile difference plot is created

* Removed redundant code

* Added information on downloading the sample data.

Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Co-authored-by: Hank Fisher <fisherh@ucar.edu>
Co-authored-by: ahijevyc <ahijevyc@ucar.edu>
Co-authored-by: TatianaBurek <tatiana@ucar.edu>
Co-authored-by: Minna Win <minnawin@kiowa.rap.ucar.edu>
Co-authored-by: Christina Kalb <kalb@ucar.edu>
Co-authored-by: Hank Fisher <fisherh@seneca.rap.ucar.edu>
Co-authored-by: hsoh-u <hsoh@ucar.edu>
Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com>
Co-authored-by: Minna Win <minnawin@seneca.rap.ucar.edu>
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED MORE DEFINITION Not yet actionable, additional definition required METplotpy: Plots priority: high High Priority requestor: METplus Team METplus Development Team requestor: NOAA/WPC NOAA Weather Prediction Center type: bug Fix something that is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants