Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #401 replaced line_logger with logger in line 698 #402

Merged
merged 4 commits into from
Nov 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion metplotpy/plots/line/line.py
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,7 @@ def write_html(self) -> None:
# save html
self.figure.write_html(html_name, include_plotlyjs=False)

self.line_logger.info(f"Finished writing to html file: {datetime.now()}")
logger.info(f"Finished writing to html file: {datetime.now()}")

def write_output_file(self) -> None:
"""
Expand Down
3 changes: 3 additions & 0 deletions test/line/nan.points1
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
NaN NaN NaN NaN 14.182521 14.703459 0.216470 0.121860 0.311080
14.615340 14.336420 14.894260 14.645345 14.338789 14.951901 0.022085 -0.056724 0.100894
14.858610 NaN 15.168714 14.981590 14.720549 15.242631 -0.076490 -0.170358 0.017378
3 changes: 1 addition & 2 deletions test/line/test_line_plot.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def test_no_nans_in_points_files():
assert nans_found == False

# Verify that the nan.points1 file does indeed trigger a "nans_found"
with open("./intermed_files/nan.points1", "r") as f:
with open("./nan.points1", "r") as f:
data = f.read()
if "NaN" in data:
nans_found = True
Expand All @@ -140,7 +140,6 @@ def test_no_nans_in_points_files():
os.remove(os.path.join(path, plot_file))
os.remove(os.path.join(intermed_path, points_file_1))
os.remove(os.path.join(intermed_path, points_file_2))
os.remove("./intermed_files/nan.points1")
except OSError as e:
# Typically when files have already been removed or
# don't exist. Ignore.
Expand Down