Issue #401 replaced line_logger with logger in line 698

[bikegeek]

Pull Request Testing

• Describe testing already performed for these changes:
  
  Ran the test_revision_series.py tests

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  
  the same as above

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

• Do these changes include sufficient testing updates? [ No]

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by Before Beta2.
  

Pull Request Checklist

See the METplus Workflow for details.

• Add any new Python packages to the METplus Components Python Requirements table.
• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[TatianaBurek]

revision_series test passed
line test failed again

[bikegeek]

It looks like the nan.point1 file is getting deleted after one of the tests is run. Will see which one is doing this and stop doing this.

…

--------------- Minna Win Pronouns: she/her National Center for Atmospheric Research DTC/Research Applications Lab Phone: 303-497-8423 *My work hours may not be your work hours. Please do not feel obliged to reply to this email outside of your normal working hours.* ---------------

On Thu, Nov 2, 2023 at 3:16 PM Tatiana Burek ***@***.***> wrote: ***@***.**** commented on this pull request. revision_series test passed line test failed again — Reply to this email directly, view it on GitHub <#402 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4UJHTX5FAWKZCQKNDGO4TYCQETTAVCNFSM6AAAAAA63OXK2GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMJRGI2TENJVGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[bikegeek]

It is now fixed.

…

--------------- Minna Win Pronouns: she/her National Center for Atmospheric Research DTC/Research Applications Lab Phone: 303-497-8423 *My work hours may not be your work hours. Please do not feel obliged to reply to this email outside of your normal working hours.* --------------- On Thu, Nov 2, 2023 at 3:39 PM Minna Win-Gildenmeister ***@***.***> wrote:

It looks like the nan.point1 file is getting deleted after one of the tests is run. Will see which one is doing this and stop doing this. --------------- Minna Win Pronouns: she/her National Center for Atmospheric Research DTC/Research Applications Lab Phone: 303-497-8423 *My work hours may not be your work hours. Please do not feel obliged to reply to this email outside of your normal working hours.* --------------- On Thu, Nov 2, 2023 at 3:16 PM Tatiana Burek ***@***.***> wrote: > ***@***.**** commented on this pull request. > > revision_series test passed > line test failed again > > — > Reply to this email directly, view it on GitHub > <#402 (review)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AA4UJHTX5FAWKZCQKNDGO4TYCQETTAVCNFSM6AAAAAA63OXK2GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMJRGI2TENJVGM> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >

[TatianaBurek]

I updated the 401 branch but the line test still fails:

# Verify that the nan.points1 file does indeed trigger a "nans_found"
>       with open("./intermed_files/nan.points1", "r") as f:
E       FileNotFoundError: [Errno 2] No such file or directory: './intermed_files/nan.points1'

[bikegeek]

I don't know why the changes I made aren't showing up in the repo. Let me re-commit. It is very disconcerting that tests that were working are suddenly no longer working! --------------- Minna Win Pronouns: she/her National Center for Atmospheric Research DTC/Research Applications Lab Phone: 303-497-8423 *My work hours may not be your work hours. Please do not feel obliged to reply to this email outside of your normal working hours.* ---------------

…

On Fri, Nov 3, 2023 at 7:30 AM Tatiana Burek ***@***.***> wrote: ***@***.**** commented on this pull request. I updated the 401 branch but the line test still fails: # Verify that the nan.points1 file does indeed trigger a "nans_found" > with open("./intermed_files/nan.points1", "r") as f: E FileNotFoundError: [Errno 2] No such file or directory: './intermed_files/nan.points1' — Reply to this email directly, view it on GitHub <#402 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4UJHVNWBBFQX7OA6HZICDYCTWYLAVCNFSM6AAAAAA63OXK2GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMJSGY4DGNJZHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[bikegeek]

I just did a clean checkout of the bugfix_401_line_revision_series branch and ran the tests for the line plot and don't see these errors. Are these showing up from running within METviewer? The github actions tests are also passing.

…

--------------- Minna Win Pronouns: she/her National Center for Atmospheric Research DTC/Research Applications Lab Phone: 303-497-8423 *My work hours may not be your work hours. Please do not feel obliged to reply to this email outside of your normal working hours.* --------------- On Fri, Nov 3, 2023 at 8:10 AM Minna Win-Gildenmeister ***@***.***> wrote:

I don't know why the changes I made aren't showing up in the repo. Let me re-commit. It is very disconcerting that tests that were working are suddenly no longer working! --------------- Minna Win Pronouns: she/her National Center for Atmospheric Research DTC/Research Applications Lab Phone: 303-497-8423 *My work hours may not be your work hours. Please do not feel obliged to reply to this email outside of your normal working hours.* --------------- On Fri, Nov 3, 2023 at 7:30 AM Tatiana Burek ***@***.***> wrote: > ***@***.**** commented on this pull request. > > I updated the 401 branch but the line test still fails: > > # Verify that the nan.points1 file does indeed trigger a "nans_found" > > with open("./intermed_files/nan.points1", "r") as f: > E FileNotFoundError: [Errno 2] No such file or directory: './intermed_files/nan.points1' > > — > Reply to this email directly, view it on GitHub > <#402 (review)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AA4UJHVNWBBFQX7OA6HZICDYCTWYLAVCNFSM6AAAAAA63OXK2GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMJSGY4DGNJZHE> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >

[bikegeek]

disregard, you're not running the tests via METviewer. --------------- Minna Win Pronouns: she/her National Center for Atmospheric Research DTC/Research Applications Lab Phone: 303-497-8423 *My work hours may not be your work hours. Please do not feel obliged to reply to this email outside of your normal working hours.* --------------- On Fri, Nov 3, 2023 at 8:24 AM Minna Win-Gildenmeister ***@***.***> wrote:

…

I just did a clean checkout of the bugfix_401_line_revision_series branch and ran the tests for the line plot and don't see these errors. Are these showing up from running within METviewer? The github actions tests are also passing. --------------- Minna Win Pronouns: she/her National Center for Atmospheric Research DTC/Research Applications Lab Phone: 303-497-8423 *My work hours may not be your work hours. Please do not feel obliged to reply to this email outside of your normal working hours.* --------------- On Fri, Nov 3, 2023 at 8:10 AM Minna Win-Gildenmeister ***@***.***> wrote: > I don't know why the changes I made aren't showing up in the repo. Let > me re-commit. It is very disconcerting that tests that were working are > suddenly no longer working! > --------------- > Minna Win > Pronouns: she/her > National Center for Atmospheric Research > DTC/Research Applications Lab > Phone: 303-497-8423 > > *My work hours may not be your work hours. Please do not feel obliged to > reply to this email outside of your normal working hours.* > --------------- > > > > On Fri, Nov 3, 2023 at 7:30 AM Tatiana Burek ***@***.***> > wrote: > >> ***@***.**** commented on this pull request. >> >> I updated the 401 branch but the line test still fails: >> >> # Verify that the nan.points1 file does indeed trigger a "nans_found" >> > with open("./intermed_files/nan.points1", "r") as f: >> E FileNotFoundError: [Errno 2] No such file or directory: './intermed_files/nan.points1' >> >> — >> Reply to this email directly, view it on GitHub >> <#402 (review)>, >> or unsubscribe >> <https://github.com/notifications/unsubscribe-auth/AA4UJHVNWBBFQX7OA6HZICDYCTWYLAVCNFSM6AAAAAA63OXK2GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMJSGY4DGNJZHE> >> . >> You are receiving this because you authored the thread.Message ID: >> ***@***.***> >> >

[TatianaBurek]

I did another pull but the test did not succeed again

[bikegeek]

Found it- when I wrote a new test for the NOAA folks to do the filtering via fixed variables, my new test is wiping out the entire intermed_files directory. I moved the nan.points1 file outside of the intermediate directory, since this is not a file that is being created during the testing process. Sorry for the confusion! --------------- Minna Win Pronouns: she/her National Center for Atmospheric Research DTC/Research Applications Lab Phone: 303-497-8423 *My work hours may not be your work hours. Please do not feel obliged to reply to this email outside of your normal working hours.* ---------------

…

On Fri, Nov 3, 2023 at 8:45 AM Tatiana Burek ***@***.***> wrote: I did another pull but the test did not succeed again — Reply to this email directly, view it on GitHub <#402 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4UJHUJ5LOY7UO4OZIJWLDYCT7PTAVCNFSM6AAAAAA63OXK2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJSGU3TIMRVGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[bikegeek]

OK, I finally have things working. Github actions is doing some weird things- like running all the workflows from previous commits- very confusing. I verified that the changes are in the bugfix_401_line_revision_series branch are in. Thanks for your help! --------------- Minna Win Pronouns: she/her National Center for Atmospheric Research DTC/Research Applications Lab Phone: 303-497-8423 *My work hours may not be your work hours. Please do not feel obliged to reply to this email outside of your normal working hours.* --------------- On Fri, Nov 3, 2023 at 8:59 AM Minna Win-Gildenmeister ***@***.***> wrote:

…

Found it- when I wrote a new test for the NOAA folks to do the filtering via fixed variables, my new test is wiping out the entire intermed_files directory. I moved the nan.points1 file outside of the intermediate directory, since this is not a file that is being created during the testing process. Sorry for the confusion! --------------- Minna Win Pronouns: she/her National Center for Atmospheric Research DTC/Research Applications Lab Phone: 303-497-8423 *My work hours may not be your work hours. Please do not feel obliged to reply to this email outside of your normal working hours.* --------------- On Fri, Nov 3, 2023 at 8:45 AM Tatiana Burek ***@***.***> wrote: > I did another pull but the test did not succeed again > > — > Reply to this email directly, view it on GitHub > <#402 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AA4UJHUJ5LOY7UO4OZIJWLDYCT7PTAVCNFSM6AAAAAA63OXK2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJSGU3TIMRVGQ> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >

[TatianaBurek]

Both tests passed