Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read of PB2NC window configuration variables #1486

Closed
22 tasks
georgemccabe opened this issue Mar 7, 2022 · 1 comment · Fixed by #1487 or #1507
Closed
22 tasks

Fix read of PB2NC window configuration variables #1486

georgemccabe opened this issue Mar 7, 2022 · 1 comment · Fixed by #1487 or #1507
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required type: bug Fix something that is not working
Milestone

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Mar 7, 2022

This was discovered in discussion #1484. More details can be found there.

Describe the Problem

Fix logic so that the following METplus config variables are read properly:
PB2NC_FILE_WINDOW_BEGIN
PB2NC_FILE_WINDOW_END
PB2NC_WINDOW_BEGIN
PB2NC_WINDOW_END

Expected Behavior

Provide a clear and concise description of what you expected to happen here.

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.
@georgemccabe georgemccabe added type: bug Fix something that is not working alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Mar 7, 2022
@georgemccabe georgemccabe added this to the METplus-4.1.0 milestone Mar 7, 2022
@georgemccabe georgemccabe self-assigned this Mar 7, 2022
georgemccabe added a commit that referenced this issue Mar 7, 2022
@georgemccabe georgemccabe linked a pull request Mar 7, 2022 that will close this issue
13 tasks
@georgemccabe
Copy link
Collaborator Author

Re-open this issue if a bugfix patch should be applied to main_v4.0 so that it is available for 4.0.X

@georgemccabe georgemccabe changed the title PB2NC_FILE_WINDOW_[BEGIN/END] no longer read properly. Fix read of PB2NC_FILE_WINDOW_[BEGIN/END] configuration variables Mar 9, 2022
@georgemccabe georgemccabe reopened this Mar 11, 2022
@georgemccabe georgemccabe changed the title Fix read of PB2NC_FILE_WINDOW_[BEGIN/END] configuration variables Fix read of PB2NC window configuration variables Mar 11, 2022
georgemccabe added a commit that referenced this issue Mar 11, 2022
…hey were previously supported in older versions. Added unit test to ensure variable is read properly
@georgemccabe georgemccabe linked a pull request Mar 11, 2022 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required type: bug Fix something that is not working
Projects
None yet
1 participant