Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create unit tests for series_by_lead.py #236

Closed
bikegeek opened this issue Jun 4, 2019 · 3 comments
Closed

Create unit tests for series_by_lead.py #236

bikegeek opened this issue Jun 4, 2019 · 3 comments
Assignees
@bikegeek
Labels
component: testing Software testing issue priority: blocker Blocker
Milestone
Backlog of Develo...

Comments

@bikegeek
Copy link
Contributor

bikegeek commented Jun 4, 2019

There aren't any unit tests for series_by_lead.py. These will be especially useful when transitioning from Python2 to Python3, as well as the obvious use of unit tests.
@bikegeek bikegeek added this to the METplus-3.0 Release milestone Jun 4, 2019
@bikegeek bikegeek added component: testing Software testing issue priority: high High Priority labels Jun 4, 2019
@JohnHalleyGotway JohnHalleyGotway added priority: blocker Blocker and removed priority: high High Priority labels Jul 15, 2019
@bikegeek
Copy link
Contributor Author

Don't forget to add to the run_pytests.sh script so that this test can be run with the other existing tests when this script is invoked.

@bikegeek bikegeek self-assigned this Aug 12, 2019
@bikegeek
Copy link
Contributor Author

bikegeek commented Dec 2, 2019

This is linked to Github Issue #331 and #333, which need to be complete before unit testing can be accomplished using pre-existing input data.

bikegeek added a commit that referenced this issue Dec 19, 2019
@bikegeek
GitHub Issue #236 series lead tests. Work in progress: 3 working tests.
e72d10f
@georgemccabe
Copy link
Collaborator

This was completed with #310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bikegeek bikegeek

Labels
component: testing Software testing issue priority: blocker Blocker
Projects
None yet
Milestone
Backlog of Development Ideas
Development

No branches or pull requests
3 participants
@bikegeek @JohnHalleyGotway @georgemccabe