Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Series by init wrapper #333

Closed
bikegeek opened this issue Dec 2, 2019 · 1 comment
Closed

Refactor Series by init wrapper #333

bikegeek opened this issue Dec 2, 2019 · 1 comment
Assignees
@bikegeek
Labels
component: testing Software testing issue component: use case wrapper
Milestone
Backlog of Develo...

Comments

@bikegeek
Copy link
Contributor

bikegeek commented Dec 2, 2019

This is similar to Github Issue #332, where the dependence on identifying a feature relative use case run is done via a process id and which is hampering the ability to run unit tests using pre-existing data.
@bikegeek bikegeek added this to the METplus Future Versions milestone Dec 2, 2019
@bikegeek bikegeek mentioned this issue Dec 2, 2019
Closed
@bikegeek bikegeek self-assigned this Dec 5, 2019
bikegeek added a commit that referenced this issue Dec 10, 2019
@bikegeek
Github Issue #333 refactor series by init wrapper to no longer use pr…
938970e 
…ocess id as a means to identify tmp files.

Now this makes unit testing using pre-existing extract tiles output possible
bikegeek added a commit that referenced this issue Dec 10, 2019
@bikegeek
Github Issue #333 Had commented out the code that was retrieving the …
f098e6d 
…process id. Remove this code to avoid any further confusion.
bikegeek added a commit that referenced this issue Dec 10, 2019
@bikegeek
Github Issue #333 After removing tmp dir (when all work is done), rec…
23f7e03 
…reate an empty one for the next wrapper in the PROCESS_LIST, otherwise there will be errors when a tmp directory that is expected is missing and intermediate files cannot be saved for later use.
bikegeek added a commit that referenced this issue Dec 10, 2019
@bikegeek
Github Issue #333. Merge branch 'feature_333_refactor_series_init' in…
460101c 
…to develop

Remove dependency on process id in series by init wrapper to allow unit testing and running series by init using pre-run extract tiles output.
@bikegeek
Copy link
Contributor Author

Removed usage of the process id in the run_at_time() and apply_series_filter() methods. Runs using pre-existing extract tiles output or as part of the originally planned end-to-end with TcPairs, ExtractTiles and SeriesByInit wrappers run in succession in one run. Also clean up tmp dir by removing it when all work is done and re-create a new, empty tmp dir for any further runs.

Merged into the 'develop' branch, but forgot to do a --no-ff merge, so the entire history of the feature_333_refactor_series_init is included in the history of the 'develop' branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bikegeek bikegeek

Labels
component: testing Software testing issue component: use case wrapper
Projects
None yet
Milestone
Backlog of Development Ideas
Development

No branches or pull requests
1 participant
@bikegeek