Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature 1653 main_v4.1 climo day_interval NA value #1672

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

georgemccabe
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

Added unit tests to ensure NA and integers can be set for day_interval

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Verify all tests pass

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    Just new unit tests added, all tests should still pass

  • Please complete this pull request review by 6/22/2022.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…al and added unit test to ensure value can be set to NA or integer
@georgemccabe georgemccabe added this to the METplus-4.1.3 Bugfix milestone Jun 22, 2022
@georgemccabe georgemccabe linked an issue Jun 22, 2022 that may be closed by this pull request
23 tasks
Copy link
Contributor

@j-opatz j-opatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the checks passed and the unit tests are behaving as expected.

@georgemccabe georgemccabe merged commit 3b8dcdd into main_v4.1 Jun 22, 2022
@georgemccabe georgemccabe deleted the bugfix_1653_main_v4.1_climo_day_interval_na branch June 22, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Bugfix: Allow NA value for <TOOL-NAME>_CLIMO_[MEAN/STDEV]_DAY_INTERVAL
2 participants