Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature #1787 allow NA instead of only integers for hour_interval #1788

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Sep 9, 2022

This change is nearly identical to #1672

Pull Request Testing

  • Describe testing already performed for these changes:

Added unit test to ensure correct behavior occurs.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Ensure all tests pass

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

  • Please complete this pull request review by 9/9/2022.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe georgemccabe added this to the METplus-4.1.4 Bugfix milestone Sep 9, 2022
@georgemccabe georgemccabe linked an issue Sep 9, 2022 that may be closed by this pull request
23 tasks
@georgemccabe
Copy link
Collaborator Author

All tests passed and the change is very similar to the other PR, so I am merging without review.

@georgemccabe georgemccabe merged commit 320ebfb into main_v4.1 Sep 9, 2022
@georgemccabe georgemccabe deleted the bugfix_1787_main_v4.1_hour_interval branch September 9, 2022 16:32
@georgemccabe georgemccabe removed the request for review from jprestop September 9, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Bugfix: Allow NA value for <TOOL-NAME>_CLIMO_[MEAN/STDEV]_HOUR_INTERVAL
1 participant