Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spurious link after images with some readers (Baka-Tsuki) #22

Closed
typhoon71 opened this issue Jun 27, 2016 · 11 comments
Closed

Spurious link after images with some readers (Baka-Tsuki) #22

typhoon71 opened this issue Jun 27, 2016 · 11 comments

Comments

@typhoon71
Copy link

In sumatrapdf there's a link after every image.
Happens to both the images at the start and those in the middle of chapters.
Doesn't happen in calibre (or sigil, but that's not a reader).
I checked in icecream too: the starting images are replaced by a bunch of links, exept the cover which is fine; the images in the middle of chapters are fine too.

@belldandu
Copy link
Collaborator

belldandu commented Jun 27, 2016

Can i get a screenshot please

I'm going to assume however that said readers are attempting to parse random url's as <a> tags from what you are saying (which is NOT standard behavior and is a bug in these readers if they are).

The contents of the desc tag are also not supposed to be shown to the user via the reader unless the image has not been rendered. See https://developer.mozilla.org/en-US/docs/Web/SVG/Element/desc

When the current SVG document fragment is rendered as SVG on visual media, desc elements are not rendered as part of the graphics.

This means that if an image exists within the svg and has been loaded then the desc tag is not rendered.

So i do recommend reporting these as bugs to the epub readers developers. Because we do not create svg elements unless there is an image.

This is a wontfix on our end if so @dteviot as our usage is perfectly valid.

@typhoon71
Copy link
Author

OK, I suppose it makes sense to file a bug to those readers (or maybe check if there's some more recent releases of them).
I suspected it could be something on the reader side since sigil was ok. But I hoped... :P
Btw, do you have any suggestion for an epub reader that is complaint?

@belldandu
Copy link
Collaborator

belldandu commented Jun 27, 2016

Well i always recommend calibre because its usable on even mobile (although some features are disabled until you buy). However i do still recommend reporting these bugs so that other people do not experience the same issues.

Feel free to link to this issue when reporting said bugs.

@typhoon71
Copy link
Author

OK, good to know calibre is loved.
Also, thanks to this I noticed my calibre wasn't up to date so I'll test again with the newer one and if the issue persist I wil report the bug to them. l suppose I can link your answer right? (the stuff about the standard)

@belldandu
Copy link
Collaborator

Yep

@dteviot
Copy link
Owner

dteviot commented Jun 27, 2016

@belldandu,
I agree that our behaviour is perfectly valid.
However, there may be people who can't update their readers and this will be fustrating for them. So I suggest we add an option to "Not include source URL in images", or something like that. Not a high priority however.

@dteviot dteviot reopened this Jun 27, 2016
@belldandu
Copy link
Collaborator

@dteviot if we do that than it should be a part of #14

@dteviot
Copy link
Owner

dteviot commented Jun 28, 2016

@belldandu.

if we do that than it should be a part of #14

Agreed. Plus, we've got a request to do so.

@belldandu
Copy link
Collaborator

Sorry tagged that wrong.

@belldandu belldandu changed the title [BUG] Spurious link after images with some readers (Baka-Tsuki) Spurious link after images with some readers (Baka-Tsuki) Jul 3, 2016
@belldandu belldandu mentioned this issue Jul 12, 2016
9 tasks
dteviot added a commit that referenced this issue Jul 25, 2016
* Remove Duplicate Images from Image Gallery (defaults to false)
* Stylesheet
* Store URL of image as SVG description. (defaults to true)  Should fix #22
* Fetch highest resolution image.  (defaults to true)
@dteviot
Copy link
Owner

dteviot commented Jul 26, 2016

Added option to turn off the description in the tag.

@belldandu
Copy link
Collaborator

Added bug in reader tag because of sumatrapdfreader/sumatrapdf#567 No need to reopen this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants