Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BakaTsuki - Empty page after Image gallery #28

Closed
typhoon71 opened this issue Jun 28, 2016 · 16 comments
Closed

BakaTsuki - Empty page after Image gallery #28

typhoon71 opened this issue Jun 28, 2016 · 16 comments
Assignees

Comments

@typhoon71
Copy link

In calibre, after the images at the start of a epub, there's a white page, just before the novel start.
Can you check if it's caused by the reader or not? It's not supposed to be there.
I can't try with sumatra because there's the link issue still around (so the page isn't empty and I don't know if it's on calibre side).

@belldandu
Copy link
Collaborator

Caused by #24

@belldandu
Copy link
Collaborator

belldandu commented Jun 28, 2016

Well As it turns out the novel illustrations bit is treated as all 1 page. So in the case of this being like a real book / LN (one that has a blank page between copyright / other junk and the story). There is no real way to fix this anyway (trust me i tried). Attempting to fix this will only cause major discrepancies between readers. @dteviot

@belldandu
Copy link
Collaborator

@dteviot we could fill in this page with something by placing some elements after all the images however doing anything other than that is not recommended at this point.

@belldandu
Copy link
Collaborator

See #31

@typhoon71
Copy link
Author

I just noticed that something similar can happen at the start of the gallery.
Check: https://www.baka-tsuki.org/project/index.php?title=Clash_of_Hexennacht:Volume1.
I think those spurious /div should be cleaned out.
I'm trying to see what happens editing manually the xhtml.
Maybe a postprocessor of sort could be an idea?

@belldandu
Copy link
Collaborator

I got rid of the spurious divs already. see #30

@typhoon71
Copy link
Author

Is it already avail/merged in sonako?

@dteviot
Copy link
Owner

dteviot commented Jun 29, 2016

@typhoon71
Yes. You can see what's been done at https://github.com/dteviot/WebToEpub/commits/sonako

All going well, I should be submitting to Google within 30 minutes.

@typhoon71
Copy link
Author

Thanks; I'll bookmark that (so I don't have t ask every time).

@belldandu
Copy link
Collaborator

Classified as a bug for now.

@dteviot
Copy link
Owner

dteviot commented Jul 10, 2016

@belldandu

I'm suspecting the problem is that there is some white space tags (either

or
) after the images. but before the end of the generated XHTML file. As the image takes an entire page, the reader puts the white space on another page. Then it reaches the end of the file, and starts the next file on a new page. So, obvious solution would be remove any whitespace from the end of the chapter. I was planning on trying this out tonight.

However, you say:

There is no real way to fix this anyway (trust me i tried). Attempting to fix this will only cause major discrepancies between readers.

Before I duplicate what you tried, can I have some more details, please?

@dteviot
Copy link
Owner

dteviot commented Jul 11, 2016

@typhoon71 @dreamer2908

Latest version in store (0.0.0.11) should fix problem with blank pages after the image gallery. (And possibly at the end of chapters as well. belldandu suggested removing the empty elements might have some unwanted side effects on some viewers. Can you please let me know how it works?

@dreamer2908
Copy link

dreamer2908 commented Jul 11, 2016

@dteviot
I've tried version 0.0.0.11. Indeed, there's no longer blank pages after the gallery or at the end of chapters in Calibre ebook viewer. I've also converted some epubs to pdfs with Calibre. The result pdfs also have no blank pages.

If the removal of empty elements is limited to the ones around headings or images then I don't think there would be unwanted effect.

Unrelated note: Ugh, apparently Calibre has problems with three dots in image filenames if I enable --smarten-punctuation option. Maybe I should report it to them when I stop being lazy.

@dteviot
Copy link
Owner

dteviot commented Jul 11, 2016

@dreamer2908
Thanks for the feedback.

Have raised #46 for the Calibre issue. Do you want to add more details on the probem? Or comment on the proposed solutions?

@dteviot
Copy link
Owner

dteviot commented Jul 12, 2016

I believe the blank page problem is sorted.

@dteviot dteviot closed this as completed Jul 12, 2016
@belldandu
Copy link
Collaborator

Oh neat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants