Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blank elements #30

Merged
merged 2 commits into from Jun 28, 2016
Merged

Remove blank elements #30

merged 2 commits into from Jun 28, 2016

Conversation

belldandu
Copy link
Collaborator

@belldandu belldandu commented Jun 28, 2016

Fixes #27 & #24
Was supposed to fix #28 by fixing #24 however because the epub readers also treat the novel illustrations as all one page even though pressing down gives you a new image (dafuq) this is unfixable without causing a crap ton of discrepancies between epub readers.

The best way to get rid of the blank page would be to simply add content to it.

@dteviot
Copy link
Owner

dteviot commented Jun 28, 2016

I'm going to display my ignorance of HTML by asking a couple of dumb questions.

  • Why did you change search by className === "toc" to id === "toc"? I'm guessing because id should be more specific? Edit: nevermind. fixes BakaTsuki - Content list (table of contents) #27
  • Should we remove empty

    sections? My understanding is that even an empty

    will add a new line. And it's possible this has been added for layout effects. e.g. extra space between lines/paragraphs for emphasis.

@belldandu
Copy link
Collaborator Author

belldandu commented Jun 28, 2016

Ok. I'll explain. On baka-tsuki the div with the attribute class of toc also has the attribute id of toc.

When a user (on the baka-tsuki pages that have the show and hide capabilities) chooses to hide the toc on the html page the attribute class of toc is changed to toc tochidden where as the attribute id remains toc.

className is javascript refers to an elements attribute class where as id in javascript refers to an elements attribute id

As for the <p> tags i see your point.

@dteviot
Copy link
Owner

dteviot commented Jun 28, 2016

@belldandu

When a user (on the baka-tsuki pages that have the show and hide
capabilities) chooses to hide the toc on the html page the attribute
"class" of "toc" is changed to "toc tochidden" where as the attribute "id"
remains "toc".

Sorry, I noticed #27 after reading this email. Comes from reading email
newest first.

On Wed, Jun 29, 2016 at 8:21 AM, Belldandu notifications@github.com wrote:

Ok. I'll explain. On baka tsuki the div with the attribute "class" of
"toc" also has the attribute "id" of toc.

When a user (on the baka-tsuki pages that have the show and hide
capabilities) chooses to hide the toc on the html page the attribute
"class" of "toc" is changed to "toc tochidden" where as the attribute "id"
remains "toc".

className is javascript refers to an elements attribute "class" where as
id in javascript refers to an elements attribute "id"

As for the new line stuff. We should in fact discard any empty

As for the

tags i see your point.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#30 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AE6w2QxIvTQY6nh1IhYYHpr55cYf0ESVks5qQYJWgaJpZM4JAHLW
.

@typhoon71
Copy link

Is it just me or the div are still there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants