Call invoker if Workflow is nil #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a directory |
|
okay, I will take a look at that |
|
Thank you, I wait for new release tag |
|
@ostafen client released v1.16.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR, I fixed a panic occuring when the client is not used inside saga.
Now, I noticed that returning nil when no
Worfklowis found has the effect of skipping the grpc call, which is not what we want when we use the client outside saga: client should behave like if no interceptor was there outside saga.@yedf2: can you confirm that calling invoker the way I'm doing has the effect of completing the call?