Skip to content

Commit

Permalink
Resolve legacy_numeric_constants clippy lints
Browse files Browse the repository at this point in the history 
    warning: usage of a legacy numeric constant
       --> syntax/discriminant.rs:298:32
        |
    298 |         max: Discriminant::pos(std::u8::MAX as u64),
        |                                ^^^^^^^^^^^^
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
        = note: `-W clippy::legacy-numeric-constants` implied by `-W clippy::all`
        = help: to override `-W clippy::all` add `#[allow(clippy::legacy_numeric_constants)]`
    help: use the associated constant instead
        |
    298 |         max: Discriminant::pos(u8::MAX as u64),
        |                                ~~~~~~~

    warning: usage of a legacy numeric constant
       --> syntax/discriminant.rs:302:32
        |
    302 |         min: Discriminant::neg(std::i8::MIN as i64),
        |                                ^^^^^^^^^^^^
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
    help: use the associated constant instead
        |
    302 |         min: Discriminant::neg(i8::MIN as i64),
        |                                ~~~~~~~

    warning: usage of a legacy numeric constant
       --> syntax/discriminant.rs:303:32
        |
    303 |         max: Discriminant::pos(std::i8::MAX as u64),
        |                                ^^^^^^^^^^^^
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
    help: use the associated constant instead
        |
    303 |         max: Discriminant::pos(i8::MAX as u64),
        |                                ~~~~~~~

    warning: usage of a legacy numeric constant
       --> syntax/discriminant.rs:308:32
        |
    308 |         max: Discriminant::pos(std::u16::MAX as u64),
        |                                ^^^^^^^^^^^^^
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
    help: use the associated constant instead
        |
    308 |         max: Discriminant::pos(u16::MAX as u64),
        |                                ~~~~~~~~

    warning: usage of a legacy numeric constant
       --> syntax/discriminant.rs:312:32
        |
    312 |         min: Discriminant::neg(std::i16::MIN as i64),
        |                                ^^^^^^^^^^^^^
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
    help: use the associated constant instead
        |
    312 |         min: Discriminant::neg(i16::MIN as i64),
        |                                ~~~~~~~~

    warning: usage of a legacy numeric constant
       --> syntax/discriminant.rs:313:32
        |
    313 |         max: Discriminant::pos(std::i16::MAX as u64),
        |                                ^^^^^^^^^^^^^
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
    help: use the associated constant instead
        |
    313 |         max: Discriminant::pos(i16::MAX as u64),
        |                                ~~~~~~~~

    warning: usage of a legacy numeric constant
       --> syntax/discriminant.rs:318:32
        |
    318 |         max: Discriminant::pos(std::u32::MAX as u64),
        |                                ^^^^^^^^^^^^^
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
    help: use the associated constant instead
        |
    318 |         max: Discriminant::pos(u32::MAX as u64),
        |                                ~~~~~~~~

    warning: usage of a legacy numeric constant
       --> syntax/discriminant.rs:322:32
        |
    322 |         min: Discriminant::neg(std::i32::MIN as i64),
        |                                ^^^^^^^^^^^^^
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
    help: use the associated constant instead
        |
    322 |         min: Discriminant::neg(i32::MIN as i64),
        |                                ~~~~~~~~

    warning: usage of a legacy numeric constant
       --> syntax/discriminant.rs:323:32
        |
    323 |         max: Discriminant::pos(std::i32::MAX as u64),
        |                                ^^^^^^^^^^^^^
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
    help: use the associated constant instead
        |
    323 |         max: Discriminant::pos(i32::MAX as u64),
        |                                ~~~~~~~~

    warning: usage of a legacy numeric constant
       --> syntax/discriminant.rs:328:32
        |
    328 |         max: Discriminant::pos(std::u64::MAX),
        |                                ^^^^^^^^^^^^^
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
    help: use the associated constant instead
        |
    328 |         max: Discriminant::pos(u64::MAX),
        |                                ~~~~~~~~

    warning: usage of a legacy numeric constant
       --> syntax/discriminant.rs:332:32
        |
    332 |         min: Discriminant::neg(std::i64::MIN),
        |                                ^^^^^^^^^^^^^
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
    help: use the associated constant instead
        |
    332 |         min: Discriminant::neg(i64::MIN),
        |                                ~~~~~~~~

    warning: usage of a legacy numeric constant
       --> syntax/discriminant.rs:333:32
        |
    333 |         max: Discriminant::pos(std::i64::MAX as u64),
        |                                ^^^^^^^^^^^^^
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
    help: use the associated constant instead
        |
    333 |         max: Discriminant::pos(i64::MAX as u64),
        |                                ~~~~~~~~
  • Loading branch information
@dtolnay
dtolnay committed Apr 6, 2024
1 parent 77c0f5b commit 8f390ea
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions syntax/discriminant.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -295,41 +295,41 @@ const LIMITS: [Limits; 8] = [
Limits {
repr: U8,
min: Discriminant::zero(),
max: Discriminant::pos(std::u8::MAX as u64),
max: Discriminant::pos(u8::MAX as u64),
},
Limits {
repr: I8,
min: Discriminant::neg(std::i8::MIN as i64),
max: Discriminant::pos(std::i8::MAX as u64),
min: Discriminant::neg(i8::MIN as i64),
max: Discriminant::pos(i8::MAX as u64),
},
Limits {
repr: U16,
min: Discriminant::zero(),
max: Discriminant::pos(std::u16::MAX as u64),
max: Discriminant::pos(u16::MAX as u64),
},
Limits {
repr: I16,
min: Discriminant::neg(std::i16::MIN as i64),
max: Discriminant::pos(std::i16::MAX as u64),
min: Discriminant::neg(i16::MIN as i64),
max: Discriminant::pos(i16::MAX as u64),
},
Limits {
repr: U32,
min: Discriminant::zero(),
max: Discriminant::pos(std::u32::MAX as u64),
max: Discriminant::pos(u32::MAX as u64),
},
Limits {
repr: I32,
min: Discriminant::neg(std::i32::MIN as i64),
max: Discriminant::pos(std::i32::MAX as u64),
min: Discriminant::neg(i32::MIN as i64),
max: Discriminant::pos(i32::MAX as u64),
},
Limits {
repr: U64,
min: Discriminant::zero(),
max: Discriminant::pos(std::u64::MAX),
max: Discriminant::pos(u64::MAX),
},
Limits {
repr: I64,
min: Discriminant::neg(std::i64::MIN),
max: Discriminant::pos(std::i64::MAX as u64),
min: Discriminant::neg(i64::MIN),
max: Discriminant::pos(i64::MAX as u64),
},
];

0 comments on commit 8f390ea

Please sign in to comment.