Prevent coercion before distributed slice typecheck #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Published to crates.io in 0.3.24, and also reported as rustsec/advisory-db#1917. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82
We use a
fn() -> &Tto prevent value coercions from applying. This does allow contravariant coercion to a subtype (a shorter lifetime), but I believe that since#tyis in astatic(cannot contain lifetimes other than the top lifetime'static) that this is not an exploitable hole. If a hole remains, it's probably to do withfor<'a>lifetime binders.I did test a few methods that fully constrain
Tto be invariant (e.g.fn(T) -> T), but they all worsened the error messages more than this does, and this appears to be sufficient.