Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected output from rustc --version: "rustc 1.52.1-nightly (gentoo)\n" #28

Closed
parazyd opened this issue May 14, 2021 · 3 comments · Fixed by #29
Closed

Unexpected output from rustc --version: "rustc 1.52.1-nightly (gentoo)\n" #28

parazyd opened this issue May 14, 2021 · 3 comments · Fixed by #29

Comments

@parazyd
Copy link

parazyd commented May 14, 2021

Hi, it seems vendors in version strings aren't supported? I'm getting an erroneous output:

error: failed to run custom build command for `rustversion v1.0.4`

Caused by:
  process didn't exit successfully: `/home/[redacted]/target/debug/build/rustversion-b03882390ede0451/build-script-build` (exit code: 1)
  --- stderr
  Error: unexpected output from `rustc --version`: "rustc 1.52.1-nightly (gentoo)\n"

  Please file an issue in https://github.com/dtolnay/rustversion

❤
@dtolnay dtolnay changed the title rustc --version unexpected output Unexpected output from rustc --version: "rustc 1.52.1-nightly (gentoo)\n" May 14, 2021
@dtolnay dtolnay mentioned this issue May 14, 2021
Merged
@dtolnay
Copy link
Owner

dtolnay commented May 14, 2021

Thanks, fixed in 1.0.5.

@gyakovlev
Copy link

thanks, had to add this to gentoo's rust-1.53.0, as it uses 1.0.4 and bootstrap failed.
we set

description = "gentoo"

and in some cases

channel = "nightly"

in config.toml

gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue Jun 18, 2021
@gyakovlev
dev-lang/rust: add rustversion patch
48168cf 
otherwise bootstrap may fail with nightly branded compiler

Upstream-issue: dtolnay/rustversion#28
Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
@dtolnay dtolnay mentioned this issue Jun 18, 2021
Merged
@parazyd
Copy link
Author

parazyd commented Jun 18, 2021 via email

JohnTitor added a commit to JohnTitor/rust that referenced this issue Jun 19, 2021
@JohnTitor
Rollup merge of rust-lang#86425 - dtolnay:rustversion, r=Mark-Simulacrum
7de3a0e 
Update rustversion to 1.0.5

1.0.4 was problematic for bootstrapping rustc on gentoo. See dtolnay/rustversion#28.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parse gentoo's version format dtolnay/rustversion
3 participants
@gyakovlev @dtolnay @parazyd