Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ? instead of unwrap in examples #129

Closed
Tracked by #139
KodrAus opened this issue Oct 21, 2017 · 7 comments
Closed
Tracked by #139

Use ? instead of unwrap in examples #129

KodrAus opened this issue Oct 21, 2017 · 7 comments

Comments

@KodrAus
Copy link

KodrAus commented Oct 21, 2017

Relevant API guidelines

Replace uses of .unwrap in examples with ? so they're a bit more idiomatic. Have a look at the API guideline examples for some ideas on how to do this.

@jansol
Copy link

jansol commented Oct 25, 2017

I'm interested in working on this

@jansol
Copy link

jansol commented Oct 25, 2017

...or not, it seems.

@KodrAus
Copy link
Author

KodrAus commented Oct 25, 2017

Oh sorry about that @jansol! Are there any other issues here you'd be interested in taking on?

@jansol
Copy link

jansol commented Oct 25, 2017

No problem. Nothing has caught my eye yet, but I haven't looked very thoroughly yet.

@anna-liao
Copy link

oh woops, just noticed that it's in progress at #144 Will look for something else :)

@KodrAus
Copy link
Author

KodrAus commented Nov 8, 2017

@anna-liao No problem! There are plenty of other issues here and in semver-parser too. If you can't find anything you like the look of also feel free to reach out on gitter.

@apopiak
Copy link

apopiak commented Dec 17, 2017

#160 resolves this, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants