libz blitz: use question mark instead of unwrap in examples #144
Conversation
src/lib.rs
Outdated
| //! bugfix_release.increment_patch(); | ||
| //! | ||
| //! assert_eq!(Ok(bugfix_release), Version::parse("1.0.1")); | ||
| //! |
There was a problem hiding this comment.
Let's remove these extra newlines before the hidden lines. Otherwise the docs will have blank lines at the end of the code blocks.
|
Thank for your guiding. |
src/lib.rs
Outdated
| @@ -158,7 +186,8 @@ | |||
| //! ``` | |||
|
|
|||
| #![doc(html_logo_url = "https://www.rust-lang.org/logos/rust-logo-128x128-blk-v2.png", | |||
| html_favicon_url = "https://www.rust-lang.org/favicon.ico")] | |||
| html_favicon_url = "https://www.rust-lang.org/favicon.ico")] | |||
| #![doc(html_root_url = "https://docs.rs/semver/0.9.0")] | |||
There was a problem hiding this comment.
this change looks unrelated?
src/lib.rs
Outdated
| @@ -70,35 +70,56 @@ | |||
| //! | |||
| //! ```{rust} | |||
| //! use semver::Version; | |||
| //! use std::error::Error; | |||
There was a problem hiding this comment.
Ah, sorry I didn't pick this up before! We should probably hide these use std::error::Error lines too since they don't actually relate to the example.
I would probably just remove that import altogether and change the function signatures to:
# fn try_increment_patch() -> Result<(), Box<::std::error::Error>> {
|
It's in conflict now. @muzikmoe if you're busy, I can resolve it for you. |
|
@opilar thank you. |
|
My comment about the unrelated change is still here, and it still needs a rebase. @muzikmoe any interest in keeping up with this PR? |
|
Triage: seems like this PR got lost in the shuffle; I'm going to give it a close. Thanks for the effort. |
Rebase pull request #141 on
master